tree aff0dd3b2db8856aba533c7421acb78847f072e3
parent 9309049544935f804b745aa4dea043fb39b2bf2a
author Martin Wilck <[EMAIL PROTECTED]> Thu, 04 Aug 2005 09:04:56 +0200
committer Jeff Garzik <[EMAIL PROTECTED]> Tue, 23 Aug 2005 09:03:39 -0400

[PATCH] Fix HD activity LED with ahci

Patch: fix wrong HD activity control by ahci driver

The ahci driver 1.0 sets the SActive bit on every transaction,
causing the LED to light up. The SActive bit is used only for
native command queuing (NCQ) which the current driver version
doesn't implement. Resetting the SActive bit is the device's
responsibility (by sending a "Set Device Bits FIS" to the
host adapter) but this is not required in response to
non-NCQ commands, and (most) devices don't. Thus the LED
stays always on. This patch fixes the LED behavior.

Spec references:, sec. 3.3.13, 5.5.1

Signed-off-by: [EMAIL PROTECTED]
Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]>

 drivers/scsi/ahci.c |    3 ---
 1 files changed, 3 deletions(-)

diff --git a/drivers/scsi/ahci.c b/drivers/scsi/ahci.c
--- a/drivers/scsi/ahci.c
+++ b/drivers/scsi/ahci.c
@@ -698,9 +698,6 @@ static int ahci_qc_issue(struct ata_queu
        struct ata_port *ap = qc->ap;
        void *port_mmio = (void *) ap->ioaddr.cmd_addr;
-       writel(1, port_mmio + PORT_SCR_ACT);
-       readl(port_mmio + PORT_SCR_ACT);        /* flush */
        writel(1, port_mmio + PORT_CMD_ISSUE);
        readl(port_mmio + PORT_CMD_ISSUE);      /* flush */
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at

Reply via email to