tree 785dbe57e3c066761cea42b97cedb4504e08ce7b
parent 61d9cdf2a9ccb9e4770d7723db8b18b8952778ce
author Paolo 'Blaisorblade' Giarrusso <[EMAIL PROTECTED]> Thu, 28 Jul 2005 
17:56:17 +0200
committer Sam Ravnborg <[EMAIL PROTECTED](none)> Thu, 28 Jul 2005 22:58:21 +0200

[PATCH] kbuild: describe Kbuild pitfall

Whitespace is significant for make, and I just fought against this... so
please apply this patch.

Signed-off-by: Paolo 'Blaisorblade' Giarrusso <[EMAIL PROTECTED]>
Signed-off-by: Sam Ravnborg <[EMAIL PROTECTED]>

 Documentation/kbuild/makefiles.txt |    6 ++++++
 1 files changed, 6 insertions(+)

diff --git a/Documentation/kbuild/makefiles.txt 
--- a/Documentation/kbuild/makefiles.txt
+++ b/Documentation/kbuild/makefiles.txt
@@ -872,7 +872,13 @@ When kbuild executes the following steps
        Assignments to $(targets) are without $(obj)/ prefix.
        if_changed may be used in conjunction with custom commands as
        defined in 6.7 "Custom kbuild commands".
        Note: It is a typical mistake to forget the FORCE prerequisite.
+       Another common pitfall is that whitespace is sometimes
+       significant; for instance, the below will fail (note the extra space
+       after the comma):
+               target: source(s) FORCE
+       #WRONG!#        $(call if_changed, ld/objcopy/gzip)
        Link target. Often LDFLAGS_$@ is used to set specific options to ld.
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at

Reply via email to