tree a2afebb1cdcb6309e2d1bc5e8c39e7895ade9236
parent 975f24bdc7d3833875309509abbc7da2b2a28234
author James Bottomley <[EMAIL PROTECTED]> Tue, 16 Aug 2005 02:13:19 -0500
committer James Bottomley <[EMAIL PROTECTED](none)> Sun, 28 Aug 2005 21:14:06 

[SCSI] fix transport class corner case after rework

If your transport class sets the ATTRIBUTE_CONTAINER_NO_CLASSDEVS flag,
then its configure method never gets called.  This patch fixes that so
that the configure method is called with a NULL classdev.

Also remove a spurious inverted comma in the transport_class comments.

Signed-off-by: James Bottomley <[EMAIL PROTECTED]>

 drivers/base/attribute_container.c |    5 +++++
 drivers/base/transport_class.c     |    2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/base/attribute_container.c 
--- a/drivers/base/attribute_container.c
+++ b/drivers/base/attribute_container.c
@@ -237,6 +237,11 @@ attribute_container_device_trigger(struc
                if (!cont->match(cont, dev))
+               if (attribute_container_no_classdevs(cont)) {
+                       fn(cont, dev, NULL);
+                       continue;
+               }
                list_for_each_entry_safe(ic, tmp, &cont->containers, node) {
                        if (dev == ic->
diff --git a/drivers/base/transport_class.c b/drivers/base/transport_class.c
--- a/drivers/base/transport_class.c
+++ b/drivers/base/transport_class.c
@@ -7,7 +7,7 @@
  * This file is licensed under GPLv2
  * The basic idea here is to allow any "device controller" (which
- * would most often be a Host Bus Adapter" to use the services of one
+ * would most often be a Host Bus Adapter to use the services of one
  * or more tranport classes for performing transport specific
  * services.  Transport specific services are things that the generic
  * command layer doesn't want to know about (speed settings, line
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at

Reply via email to