Commit:     519ce3ec76bf5c068e575800a9977659f7cccec4
Parent:     eff0df65da81c75084d936e86854a3418347c27f
Author:     Venkatesh Pallipadi <[EMAIL PROTECTED]>
AuthorDate: Tue Oct 3 12:27:10 2006 -0700
Committer:  Dave Jones <[EMAIL PROTECTED]>
CommitDate: Sun Oct 15 19:57:10 2006 -0400

    [CPUFREQ][1/8] acpi-cpufreq: software coordination and handle all CPUs in 
the group
    This patchset has refresh/rebase of a bunch of patches/bugfixes related to
    acpi-cpufreq that were sent earlier on this list.
    patch 1/8
     Patch that fixes a bug in swcoordination code in acpi-cpufreq
    patch 2/8 through patch 7/8
     Grand unification of ACPI based speedstep-centrino and acpi-cpufreq 
     ACPI allows P-state transitions in multiple ways. Like using IO ports or 
     processor native method (MSR). Without this patch, IO port based P-state
     transitions are handled in acpi-cpufreq driver and MSR based transitions on
     Intel CPUs are handled in speedstep-centrino driver. Even though most of 
     code in these two drivers should be similar, except for final 
     of frequency (one driver does it using IO port and other does it through
     MSR), we have duplicated code in these two drivers. There are also issues
     around BIOSes supporting both MSR and IO port and which driver should be
     loaded first in standard installations.
     The patchset combines functionality of these two driver into acpi-cpufreq
     driver. ACPI based functionality in speedstep-centrino is marked deprecated
     and will be removed in future. speedstep-centrino will continue to work
     on systems that depend on older non-ACPI table based P-state chanes.
     * 2/8 - Patch that reorganizes the code in acpi-cpufreq, cleaning it up
     a little and making it easier to add MSR support later.
     * 3/8 - Pull in the MSR based transition support into acpi-cpufreq.
     * 4/8 - Mark speedstep-centrino deprecated. Change the order in Makefile to
     load acpi-cpufreq first and speedstep-centrino later, in cases where both
     are configured in.
     * 5/8 - lindent acpi-cpufreq.c
     * 6/8 - Minor change to eliminate the check of current frequency on
     notifications. We can use last set frequency instead.
     * 7/8 - Make cpufreq->get of acpi_cpufreq work correctly again.
     There will be a patch in future that removes ACPI based support in
     speedstep-centrino in coming months.
    patch 8/8
    Add support for IA32_APERF and IA32_MPERF MSR and get the actual frequency
    from these MSRs and use it to determine the next frequency target in 
    This patch:
    There is a bug in software coordination patch in acpi-cpufreq, due to which
    frequency will only be set on first CPU of any coordinated group.
    Bug identified by Denis, was not recognised earlier as there are no 
    yet that use software coordination with acpi-cpufreq driver.
    Signed-off-by: Denis Sadykov <[EMAIL PROTECTED]>
    Signed-off-by: Venkatesh Pallipadi <[EMAIL PROTECTED]>
    Signed-off-by: Dave Jones <[EMAIL PROTECTED]>
 arch/i386/kernel/cpu/cpufreq/acpi-cpufreq.c |   11 ++++++++---
 1 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/arch/i386/kernel/cpu/cpufreq/acpi-cpufreq.c 
index 57c880b..e902d97 100644
--- a/arch/i386/kernel/cpu/cpufreq/acpi-cpufreq.c
+++ b/arch/i386/kernel/cpu/cpufreq/acpi-cpufreq.c
@@ -197,6 +197,7 @@ acpi_cpufreq_target (
        unsigned int relation)
        struct cpufreq_acpi_io *data = acpi_io_data[policy->cpu];
+       struct cpufreq_acpi_io *cpudata;
        struct acpi_processor_performance *perf;
        struct cpufreq_freqs freqs;
        cpumask_t online_policy_cpus;
@@ -260,7 +261,8 @@ acpi_cpufreq_target (
-               result = acpi_processor_set_performance (data, j, next_state);
+               cpudata = acpi_io_data[j];
+               result = acpi_processor_set_performance(cpudata, j, next_state);
                if (result) {
                        result = -EAGAIN;
@@ -287,8 +289,11 @@ acpi_cpufreq_target (
                if (!cpus_empty(covered_cpus)) {
                        for_each_cpu_mask(j, covered_cpus) {
-                               policy->cpu = j;
-                               acpi_processor_set_performance (data, 
+                               cpus_clear(set_mask);
+                               cpu_set(j, set_mask);
+                               set_cpus_allowed(current, set_mask);
+                               cpudata = acpi_io_data[j];
+                               acpi_processor_set_performance(cpudata,
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at

Reply via email to