Commit:     29a7f3ada7fea5510504c5359c3f70d109aeb055
Parent:     65c333367b1aea57d58168ad3dc1df27b0227401
Author:     Mathieu Desnoyers <[EMAIL PROTECTED]>
AuthorDate: Fri Nov 24 13:51:14 2006 -0500
Committer:  Greg Kroah-Hartman <[EMAIL PROTECTED]>
CommitDate: Wed Dec 13 15:38:45 2006 -0800

    DebugFS : file/directory removal fix
    Fix file and directory removal in debugfs. Add inotify support for file 
    The following scenario :
    create dir a
    create dir a/b
    cd a/b (some process goes in cwd a/b)
    rmdir a/b
    rmdir a
    fails due to the fact that "a" appears to be non empty. It is because
    the "b" dentry is not deleted from "a" and still in use. The same
    problem happens if "b" is a file. d_delete is nice enough to know when
    it needs to unhash and free the dentry if nothing else is using it or,
    if someone is using it, to remove it from the hash queues and wait for
    it to be deleted when it has no users.
    The nice side-effect of this fix is that it calls the file removal
    Signed-off-by: Mathieu Desnoyers <[EMAIL PROTECTED]>
    Signed-off-by: Greg Kroah-Hartman <[EMAIL PROTECTED]>
 fs/debugfs/inode.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/fs/debugfs/inode.c b/fs/debugfs/inode.c
index 554f4a9..c692487 100644
--- a/fs/debugfs/inode.c
+++ b/fs/debugfs/inode.c
@@ -286,6 +286,7 @@ void debugfs_remove(struct dentry *dentry)
        if (debugfs_positive(dentry)) {
                if (dentry->d_inode) {
+                       dget(dentry);
                        if (S_ISDIR(dentry->d_inode->i_mode)) {
                                ret = simple_rmdir(parent->d_inode, dentry);
                                if (ret)
@@ -295,6 +296,9 @@ void debugfs_remove(struct dentry *dentry)
                        } else
                                simple_unlink(parent->d_inode, dentry);
+                       if (!ret)
+                               d_delete(dentry);
+                       dput(dentry);
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at

Reply via email to