Commit:     a52de245ef0b6217a56fb2472ff65c3a196cafd5
Parent:     89f97ad1894ab518b05b798906085fb3d1b2d00f
Author:     Mike Miller <[EMAIL PROTECTED]>
AuthorDate: Mon Dec 18 11:00:14 2006 +0100
Committer:  Jens Axboe <[EMAIL PROTECTED]>
CommitDate: Mon Dec 18 11:00:14 2006 +0100

    [PATCH] cciss: fix XFER_READ/XFER_WRITE in do_cciss_request
    This patch fixes a stupid bug. Sometime during the 2tb enhancement I ended 
    replacing the macros XFER_READ and XFER_WRITE with h->cciss_read and
    h->cciss_write respectively. It seemed to work somehow at least on x86_64 
    ia64. I don't know how. But people started complaining about command 
    on older controllers like the 64xx series and only on ia32. This resolves 
    issue reproduced in our lab. Please consider this for inclusion.
    Signed-off-by: Mike Miller <[EMAIL PROTECTED]>
    Signed-off-by: Jens Axboe <[EMAIL PROTECTED]>
 drivers/block/cciss.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/block/cciss.c b/drivers/block/cciss.c
index 67a6d4a..9d2ddb2 100644
--- a/drivers/block/cciss.c
+++ b/drivers/block/cciss.c
@@ -2492,7 +2492,7 @@ static void do_cciss_request(request_queue_t *q)
        c->Request.Type.Type = TYPE_CMD;        // It is a command.
        c->Request.Type.Attribute = ATTR_SIMPLE;
        c->Request.Type.Direction =
-           (rq_data_dir(creq) == READ) ? h->cciss_read : h->cciss_write;
+           (rq_data_dir(creq) == READ) ? XFER_READ : XFER_WRITE;
        c->Request.Timeout = 0; // Don't time out
        c->Request.CDB[0] =
            (rq_data_dir(creq) == READ) ? h->cciss_read : h->cciss_write;
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at

Reply via email to