Commit:     9d7ac8be4b48737ad1cebd94ed754a269f360708
Parent:     e903387f1ebe3a7ddb93cd49c38341d3632df528
Author:     Thomas Gleixner <[EMAIL PROTECTED]>
AuthorDate: Fri Dec 22 01:08:14 2006 -0800
Committer:  Linus Torvalds <[EMAIL PROTECTED]>
CommitDate: Fri Dec 22 08:55:48 2006 -0800

    [PATCH] genirq: fix irq flow handler uninstall
    The sanity check for no_irq_chip in __set_irq_hander() is unconditional on
    both install and uninstall of an handler.  This triggers false warnings and
    replaces no_irq_chip by dummy_irq_chip in the uninstall case.
    Check only, when a real handler is installed.
    Signed-off-by: Thomas Gleixner <[EMAIL PROTECTED]>
    Acked-by: Ingo Molnar <[EMAIL PROTECTED]>
    Acked-by: Sylvain Munaut <[EMAIL PROTECTED]>
    Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
    Signed-off-by: Linus Torvalds <[EMAIL PROTECTED]>
 kernel/irq/chip.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c
index 1c1b712..d27b258 100644
--- a/kernel/irq/chip.c
+++ b/kernel/irq/chip.c
@@ -517,8 +517,7 @@ __set_irq_handler(unsigned int irq, irq_flow_handler_t 
handle, int is_chained,
        if (!handle)
                handle = handle_bad_irq;
-       if (desc->chip == &no_irq_chip) {
+       else if (desc->chip == &no_irq_chip) {
                printk(KERN_WARNING "Trying to install %sinterrupt handler "
                       "for IRQ%d\n", is_chained ? "chained " : "", irq);
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at

Reply via email to