Gitweb:     
http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=5e40508e5fee2dac7b04d5bc5b5ef3b452f0a899
Commit:     5e40508e5fee2dac7b04d5bc5b5ef3b452f0a899
Parent:     449d4dd5add718578eb2e6671168de9f67dd239c
Author:     Akinobu Mita <[EMAIL PROTECTED]>
AuthorDate: Fri Dec 22 01:10:28 2006 -0800
Committer:  Linus Torvalds <[EMAIL PROTECTED]>
CommitDate: Fri Dec 22 08:55:50 2006 -0800

    [PATCH] tlclk: delete unnecessary sysfs_remove_group
    
    It is unnecessary and invalid to call sysfs_remove_group() after
    sysfs_create_group() failure.
    
    Cc: Sebastien Bouchard <[EMAIL PROTECTED]>
    Cc: Mark Gross <[EMAIL PROTECTED]>
    Signed-off-by: Akinobu Mita <[EMAIL PROTECTED]>
    Cc: Greg KH <[EMAIL PROTECTED]>
    Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
    Signed-off-by: Linus Torvalds <[EMAIL PROTECTED]>
---
 drivers/char/tlclk.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/drivers/char/tlclk.c b/drivers/char/tlclk.c
index 244d30a..448d508 100644
--- a/drivers/char/tlclk.c
+++ b/drivers/char/tlclk.c
@@ -807,8 +807,6 @@ static int __init tlclk_init(void)
                        &tlclk_attribute_group);
        if (ret) {
                printk(KERN_ERR "tlclk: failed to create sysfs device 
attributes.\n");
-               sysfs_remove_group(&tlclk_device->dev.kobj,
-                       &tlclk_attribute_group);
                goto out5;
        }
 
-
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to