Commit:     a416aba637dcb4127595c02a59041cd278422f7e
Parent:     c4a68306b9c0939b3facdad2cc5e34d660ff463a
Author:     Ard van Breemen <[EMAIL PROTECTED]>
AuthorDate: Fri Jan 5 16:36:20 2007 -0800
Committer:  Linus Torvalds <[EMAIL PROTECTED]>
CommitDate: Fri Jan 5 23:55:21 2007 -0800

    [PATCH] kernelparams: detect if and which parameter parsing enabled irq's
    The parsing of some kernel parameters seem to enable irq's at a stage that
    irq's are not supposed to be enabled (Particularly the ide kernel 
    Having irq's enabled before the irq controller is initialized might lead to 
    kernel panic.  This patch only detects this behaviour and warns about wich
    parameter caused it.
    [EMAIL PROTECTED]: cleanups]
    Signed-off-by: Ard van Breemen <[EMAIL PROTECTED]>
    Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
    Signed-off-by: Linus Torvalds <[EMAIL PROTECTED]>
 kernel/params.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/kernel/params.c b/kernel/params.c
index f406655..718945d 100644
--- a/kernel/params.c
+++ b/kernel/params.c
@@ -143,9 +143,15 @@ int parse_args(const char *name,
        while (*args) {
                int ret;
+               int irq_was_disabled;
                args = next_arg(args, &param, &val);
+               irq_was_disabled = irqs_disabled();
                ret = parse_one(param, val, params, num, unknown);
+               if (irq_was_disabled && !irqs_disabled()) {
+                       printk(KERN_WARNING "parse_args(): option '%s' enabled "
+                                       "irq's!\n", param);
+               }
                switch (ret) {
                case -ENOENT:
                        printk(KERN_ERR "%s: Unknown parameter `%s'\n",
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at

Reply via email to