Commit:     3771a450cf47fa64f36c53ba61e36aa2ec84a86b
Parent:     9dbeeec91e8f4a200ac56af5004473fa6099520f
Author:     Vivek Goyal <[EMAIL PROTECTED]>
AuthorDate: Fri Jan 5 16:36:34 2007 -0800
Committer:  Linus Torvalds <[EMAIL PROTECTED]>
CommitDate: Fri Jan 5 23:55:23 2007 -0800

    [PATCH] i386: modpost smpboot code warning fix
    o Currently synchronize_tsc_ap() is of type __init. It is called by
      smp_callin() which is of type __cpuinit. So synchronize_tsc_ap()
      should be of type __cpuinit.
    o Modpost generates warnings for i386 if CONFIG_RELOCATABLE=y and
    WARNING: vmlinux - Section mismatch: reference to from .text 
between 'start_secondary' (at offset 0xc01164dc) and 'initialize_secondary'
    WARNING: vmlinux - Section mismatch: reference to from .text 
between 'start_secondary' (at offset 0xc01164e8) and 'initialize_secondary'
    o tsc is of type __initdata. It should be of type __cpuinitdata.
    Signed-off-by: Vivek Goyal <[EMAIL PROTECTED]>
    Cc: Andi Kleen <[EMAIL PROTECTED]>
    Cc: "Eric W. Biederman" <[EMAIL PROTECTED]>
    Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
    Signed-off-by: Linus Torvalds <[EMAIL PROTECTED]>
 arch/i386/kernel/smpboot.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/i386/kernel/smpboot.c b/arch/i386/kernel/smpboot.c
index aef39be..300d9b3 100644
--- a/arch/i386/kernel/smpboot.c
+++ b/arch/i386/kernel/smpboot.c
@@ -227,7 +227,7 @@ static struct {
        atomic_t count_start;
        atomic_t count_stop;
        unsigned long long values[NR_CPUS];
-} tsc __initdata = {
+} tsc __cpuinitdata = {
        .start_flag = ATOMIC_INIT(0),
        .count_start = ATOMIC_INIT(0),
        .count_stop = ATOMIC_INIT(0),
@@ -332,7 +332,7 @@ static void __init synchronize_tsc_bp(void)
-static void __init synchronize_tsc_ap(void)
+static void __cpuinit synchronize_tsc_ap(void)
        int i;
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at

Reply via email to