Commit:     d98f92371461c5c8cc24e12a212c59b3f437b581
Parent:     f75f369fd783d194cb45632617561ca4d7045849
Author:     Davy Chan <[EMAIL PROTECTED]>
AuthorDate: Fri Jan 5 13:56:46 2007 +0800
Committer:  Ralf Baechle <[EMAIL PROTECTED]>
CommitDate: Mon Jan 8 21:41:04 2007 +0000

    [MIPS] pnx8550: Fix write_config_byte() PCI config space accessor
    There's a serious typo in the function:
    The parameter passed to the function config_access() is PCI_CMD_CONFIG_READ
    instead of PCI_CMD_CONFIG_WRITE. This renders any attempts to write
    a single byte to the PCI configuration registers useless.
    This problem does not exist for write_config_word() nor 
    This problem has been there since kernel v2.6.17 and is still there
    as of kernel v2.6.19.1.
    Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]>
 arch/mips/pci/ops-pnx8550.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/mips/pci/ops-pnx8550.c b/arch/mips/pci/ops-pnx8550.c
index 454b65c..f556b7a 100644
--- a/arch/mips/pci/ops-pnx8550.c
+++ b/arch/mips/pci/ops-pnx8550.c
@@ -202,7 +202,7 @@ write_config_byte(struct pci_bus *bus, unsigned int devfn, 
int where, u8 val)
-       err = config_access(PCI_CMD_CONFIG_READ, bus, devfn, where, ~(1 << 
(where & 3)), &data);
+       err = config_access(PCI_CMD_CONFIG_WRITE, bus, devfn, where, ~(1 << 
(where & 3)), &data);
        return err;
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at

Reply via email to