Commit:     e96763d6e52c22a8821466e4d01c0c995b8087be
Parent:     4a5d107a9a79ef3404209a43866554cba451dda4
Author:     Vivek Goyal <[EMAIL PROTECTED]>
AuthorDate: Thu Jan 11 01:52:44 2007 +0100
Committer:  Andi Kleen <[EMAIL PROTECTED]>
CommitDate: Thu Jan 11 01:52:44 2007 +0100

    [PATCH] i386: make apic probe function non-init
    o struct genapic contains pointer to probe() function which is of type
      __init. Hence MODPOST generates warning if kernel is compiled with
      CONFIG_RELOCATABLE=y for i386.
    WARNING: vmlinux - Section mismatch: reference to .init.text: from .data 
between 'apic_summit' (at offset 0xc058b504) and 'apic_bigsmp'
    WARNING: vmlinux - Section mismatch: reference to .init.text: from .data 
between 'apic_bigsmp' (at offset 0xc058b5a4) and 'cpu.4471'
    WARNING: vmlinux - Section mismatch: reference to .init.text: from .data 
between 'apic_es7000' (at offset 0xc058b644) and 'apic_default'
    WARNING: vmlinux - Section mismatch: reference to .init.text: from .data 
between 'apic_default' (at offset 0xc058b6e4) and 'interrupt'
    o One of the possible options is to put special case check in MODPOST to
      not emit warnings for this case but I think it is not a very good option
      in terms of maintenance.
    o Another option is to make probe() function non __init. Anyway this 
      is really small so not freeing this memory after init is not a big deal.
      Secondly, from a programming perspective, probably genapic should not
      provide pointers to functions which have been freed as genapic is non
      __init and is used even after initialization is complete.
    Signed-off-by: Vivek Goyal <[EMAIL PROTECTED]>
    Signed-off-by: Andi Kleen <[EMAIL PROTECTED]>
    Cc: "Eric W. Biederman" <[EMAIL PROTECTED]>
    Cc: Andi Kleen <[EMAIL PROTECTED]>
    Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
 arch/i386/mach-generic/bigsmp.c  |    2 +-
 arch/i386/mach-generic/default.c |    2 +-
 arch/i386/mach-generic/es7000.c  |    2 +-
 arch/i386/mach-generic/summit.c  |    2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/i386/mach-generic/bigsmp.c b/arch/i386/mach-generic/bigsmp.c
index 33d9f93..8a210fa 100644
--- a/arch/i386/mach-generic/bigsmp.c
+++ b/arch/i386/mach-generic/bigsmp.c
@@ -45,7 +45,7 @@ static struct dmi_system_id __initdata bigsmp_dmi_table[] = {
-static __init int probe_bigsmp(void)
+static int probe_bigsmp(void)
        if (def_to_bigsmp)
                dmi_bigsmp = 1;
diff --git a/arch/i386/mach-generic/default.c b/arch/i386/mach-generic/default.c
index 96c1982..8685208 100644
--- a/arch/i386/mach-generic/default.c
+++ b/arch/i386/mach-generic/default.c
@@ -18,7 +18,7 @@
 #include <asm/mach-default/mach_mpparse.h>
 /* should be called last. */
-static __init int probe_default(void)
+static int probe_default(void)
        return 1;
diff --git a/arch/i386/mach-generic/es7000.c b/arch/i386/mach-generic/es7000.c
index aa144d8..b8963a5 100644
--- a/arch/i386/mach-generic/es7000.c
+++ b/arch/i386/mach-generic/es7000.c
@@ -19,7 +19,7 @@
 #include <asm/mach-es7000/mach_mpparse.h>
 #include <asm/mach-es7000/mach_wakecpu.h>
-static __init int probe_es7000(void)
+static int probe_es7000(void)
        /* probed later in mptable/ACPI hooks */
        return 0;
diff --git a/arch/i386/mach-generic/summit.c b/arch/i386/mach-generic/summit.c
index f7e5d66..74883cc 100644
--- a/arch/i386/mach-generic/summit.c
+++ b/arch/i386/mach-generic/summit.c
@@ -18,7 +18,7 @@
 #include <asm/mach-summit/mach_ipi.h>
 #include <asm/mach-summit/mach_mpparse.h>
-static __init int probe_summit(void)
+static int probe_summit(void)
        /* probed later in mptable/ACPI hooks */
        return 0;
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at

Reply via email to