Gitweb:     
http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=c430ca1e16b2b4b30f567806c73e270caea8db1d
Commit:     c430ca1e16b2b4b30f567806c73e270caea8db1d
Parent:     a8b3485287731978899ced11f24628c927890e78
Author:     Thierry MERLE <[EMAIL PROTECTED]>
AuthorDate: Fri Dec 29 20:32:08 2006 -0300
Committer:  Mauro Carvalho Chehab <[EMAIL PROTECTED]>
CommitDate: Mon Jan 15 16:25:24 2007 -0200

    V4L/DVB (5019): Fix the frame->grabstate update in read() entry point.
    
    The Coverity checker spotted that in usbvision_v4l2_read(), the variable
    "frmx" is never assigned any value different from -1, but it's used an
    an array index in "usbvision->frame[frmx]".
    Thanks to Adrian Bunk <[EMAIL PROTECTED]> for warning about that.
    
    Signed-off-by: Thierry MERLE <[EMAIL PROTECTED]>
    Signed-off-by: Mauro Carvalho Chehab <[EMAIL PROTECTED]>
---
 drivers/media/video/usbvision/usbvision-video.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/drivers/media/video/usbvision/usbvision-video.c 
b/drivers/media/video/usbvision/usbvision-video.c
index 8c7eba2..7243337 100644
--- a/drivers/media/video/usbvision/usbvision-video.c
+++ b/drivers/media/video/usbvision/usbvision-video.c
@@ -1080,7 +1080,6 @@ static ssize_t usbvision_v4l2_read(struct file *file, 
char *buf,
        int noblock = file->f_flags & O_NONBLOCK;
        unsigned long lock_flags;
 
-       int frmx = -1;
        int ret,i;
        struct usbvision_frame *frame;
 
@@ -1155,7 +1154,7 @@ static ssize_t usbvision_v4l2_read(struct file *file, 
char *buf,
                frame->bytes_read = 0;
 
                /* Mark it as available to be used again. */
-               usbvision->frame[frmx].grabstate = FrameState_Unused;
+               frame->grabstate = FrameState_Unused;
 /*     } */
 
        return count;
-
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to