Commit:     4ed381ee559ebfab32d3b21896c204992c36179a
Parent:     8bcc24127be12967588db0ad0e614be937ee1d5a
Author:     James Bottomley <[EMAIL PROTECTED]>
AuthorDate: Mon Dec 11 09:47:06 2006 -0600
Committer:  James Bottomley <[EMAIL PROTECTED]>
CommitDate: Wed Jan 3 16:57:35 2007 -0600

    [SCSI] scsi_transport_spi: fix sense buffer size error
    The code does this:
    unsigned char sense[SCSI_SENSE_BUFFERSIZE];
    scsi_normalize_sense(sense, sizeof(*sense), sshdr)
    however the sizeof will return 1 not 96 which means the sense data will
    have no valid ASC/ASCQ values.  Fix by putting the correct sense size.
    The only affected case for this would have been the DV buffer sanity
    check failure, which is fortunately quite rare.
    Signed-off-by: James Bottomley <[EMAIL PROTECTED]>
 drivers/scsi/scsi_transport_spi.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/scsi/scsi_transport_spi.c 
index 3fded48..014d7fe 100644
--- a/drivers/scsi/scsi_transport_spi.c
+++ b/drivers/scsi/scsi_transport_spi.c
@@ -122,7 +122,7 @@ static int spi_execute(struct scsi_device *sdev, const void 
                        if (!sshdr)
                                sshdr = &sshdr_tmp;
-                       if (scsi_normalize_sense(sense, sizeof(*sense),
+                       if (scsi_normalize_sense(sense, SCSI_SENSE_BUFFERSIZE,
                            && sshdr->sense_key == UNIT_ATTENTION)
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at

Reply via email to