Commit:     bcdddfb66cc998252d34758ce4109cedc0d24a5c
Parent:     0f2452855d86901ba3766826ccb5606ea4e15ab9
Author:     Linus Torvalds <[EMAIL PROTECTED]>
AuthorDate: Tue Jan 30 14:11:12 2007 -0800
Committer:  Linus Torvalds <[EMAIL PROTECTED]>
CommitDate: Tue Jan 30 14:11:12 2007 -0800

    Revert "net: ifb error path loop fix"
    This reverts commit 0c0b3ae68ec93b1db5c637d294647d1cca0df763.
    Quoth David:
      "Jeff, please revert
       It's wrong.  We had a lengthy analysis of this piece of code
       several months ago, and it is correct.
       Consider, if we run the loop and we get an error
       the following happens:
       1) attempt of ifb_init_one(i) fails, therefore we should
          not try to "ifb_free_one()" on "i" since it failed
       2) the loop iteration first increments "i", then it
          check for error
       Therefore we must decrement "i" twice before the first
       free during the cleanup.  One to "undo" the for() loop
       increment, and one to "skip" the ifb_init_one() case which
    Reported-by: David Miller <[EMAIL PROTECTED]>
    Acked-by: Jeff Garzik <[EMAIL PROTECTED]>
    Cc: Andrew Morton <[EMAIL PROTECTED]>
    Signed-off-by: Linus Torvalds <[EMAIL PROTECTED]>
 drivers/net/ifb.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/net/ifb.c b/drivers/net/ifb.c
index c4ca7c9..ca2b21f 100644
--- a/drivers/net/ifb.c
+++ b/drivers/net/ifb.c
@@ -271,7 +271,8 @@ static int __init ifb_init_module(void)
        for (i = 0; i < numifbs && !err; i++)
                err = ifb_init_one(i);
        if (err) {
-               while (i--)
+               i--;
+               while (--i >= 0)
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at

Reply via email to