Gitweb:     
http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=befede3dabd204e9c546cbfbe391b29286c57da2
Commit:     befede3dabd204e9c546cbfbe391b29286c57da2
Parent:     3424a65d717ca87ce11acfb03cfd2f713886bfb4
Author:     Seokmann Ju <[EMAIL PROTECTED]>
AuthorDate: Tue Jan 9 11:37:52 2007 -0800
Committer:  James Bottomley <[EMAIL PROTECTED]>
CommitDate: Sat Jan 13 13:59:10 2007 -0600

    [SCSI] qla2xxx: correct locking while call starget_for_each_device()
    
    Removed spin_unlock_irq()/spin_lock_irq() pairs surrounding
    starget_for_each_device() calls.
    As Matthew W. pointed out, starget_for_each_device() can be called under
    a spinlock being held.
    The change has been tested and verified on qla2xxx.ko module.
    Thanks Matthew W. and Hisashi H. for help.
    
    Signed-off-by: Andrew Vasquez <[EMAIL PROTECTED]>
    Signed-off-by: Seokmann Ju <[EMAIL PROTECTED]>
    Signed-off-by: James Bottomley <[EMAIL PROTECTED]>
---
 drivers/scsi/qla2xxx/qla_isr.c |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c
index d3b6df4..b95fcb2 100644
--- a/drivers/scsi/qla2xxx/qla_isr.c
+++ b/drivers/scsi/qla2xxx/qla_isr.c
@@ -650,10 +650,8 @@ qla2x00_ramp_up_queue_depth(scsi_qla_host_t *ha, srb_t *sp)
            fcport->last_queue_full + ql2xqfullrampup * HZ))
                return;
 
-       spin_unlock_irq(&ha->hardware_lock);
        starget_for_each_device(sdev->sdev_target, fcport,
            qla2x00_adjust_sdev_qdepth_up);
-       spin_lock_irq(&ha->hardware_lock);
 }
 
 /**
@@ -923,10 +921,8 @@ qla2x00_status_entry(scsi_qla_host_t *ha, void *pkt)
 
                        /* Adjust queue depth for all luns on the port. */
                        fcport->last_queue_full = jiffies;
-                       spin_unlock_irq(&ha->hardware_lock);
                        starget_for_each_device(cp->device->sdev_target,
                            fcport, qla2x00_adjust_sdev_qdepth_down);
-                       spin_lock_irq(&ha->hardware_lock);
                        break;
                }
                if (lscsi_status != SS_CHECK_CONDITION)
-
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to