Commit:     fe3b5bfe73ace420709f0cfb198b0ffc704bd38b
Parent:     57ba07dc54b7657e69fe8ac42d83df21e415c85b
Author:     Darrick J. Wong <[EMAIL PROTECTED]>
AuthorDate: Thu Jan 11 14:15:35 2007 -0800
Committer:  James Bottomley <[EMAIL PROTECTED]>
CommitDate: Sat Jan 13 16:20:03 2007 -0600

    [SCSI] libsas: sysfs phy control attributes should not be S_IWUGO
    Allowing the phy reset controls to be world-triggerable does not seem like
    a terribly good idea because SAS devices can be disrupted (and ATA devices
    are really disrupted) by a phy reset.  By default only root should be able
    to do things like that.
    Signed-off-by: Darrick J. Wong <[EMAIL PROTECTED]>
    Signed-off-by: James Bottomley <[EMAIL PROTECTED]>
 drivers/scsi/scsi_transport_sas.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/scsi_transport_sas.c 
index e57b02e..bfbcf5f 100644
--- a/drivers/scsi/scsi_transport_sas.c
+++ b/drivers/scsi/scsi_transport_sas.c
@@ -1446,10 +1446,10 @@ static int sas_user_scan(struct Scsi_Host *shost, uint 
        SETUP_TEMPLATE(phy_attrs, field, S_IRUGO, i->f->func)
 #define SETUP_PHY_ATTRIBUTE_WRONLY(field)                              \
-       SETUP_TEMPLATE(phy_attrs, field, S_IWUGO, 1)
+       SETUP_TEMPLATE(phy_attrs, field, S_IWUSR, 1)
 #define SETUP_OPTIONAL_PHY_ATTRIBUTE_WRONLY(field, func)               \
-       SETUP_TEMPLATE(phy_attrs, field, S_IWUGO, i->f->func)
+       SETUP_TEMPLATE(phy_attrs, field, S_IWUSR, i->f->func)
 #define SETUP_END_DEV_ATTRIBUTE(field)                                 \
        SETUP_TEMPLATE(end_dev_attrs, field, S_IRUGO, 1)
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at

Reply via email to