Commit:     3b6e9fafc40e36f50f0bd0f1ee758eecd79f1098
Parent:     a5364c5a311f73eade88f37bf5b614797ce30ec9
Author:     Darrick J. Wong <[EMAIL PROTECTED]>
AuthorDate: Fri Jan 26 14:08:41 2007 -0800
Committer:  James Bottomley <[EMAIL PROTECTED]>
CommitDate: Sat Jan 27 10:04:58 2007 -0600

    [SCSI] libsas: Fix incorrect sas_port deformation in sas_form_port
    Currently, sas_form_port checks the given asd_sas_phy's sas_phy to see if
    there's already a port attached.  If so, the SAS addresses of the port and
    the phy are compared to determine if we need to detach from the port
    because the addresses don't match or if we can stop; the SAS address stored
    in the sas_port reflects whatever device _was_ attached to the port/phy, and
    the SAS address stored in the sas_port reflects whatever device we just
    discovered.  As written, the code detaches from the port if the addresses
    _do_ match, and prints an error if they do _not_ match.  I believe this to
    be incorrect, as it seems more logical to keep the port if the addresses
    match (i.e. the phy was reset but the device didn't change), and detach it
    they do not (i.e. the device changed).
    Signed-off-by: Darrick J. Wong <[EMAIL PROTECTED]>
    Signed-off-by: James Bottomley <[EMAIL PROTECTED]>
 drivers/scsi/libsas/sas_port.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/scsi/libsas/sas_port.c b/drivers/scsi/libsas/sas_port.c
index a796ae3..e1e2d08 100644
--- a/drivers/scsi/libsas/sas_port.c
+++ b/drivers/scsi/libsas/sas_port.c
@@ -46,7 +46,7 @@ static void sas_form_port(struct asd_sas_phy *phy)
        if (port) {
                if (memcmp(port->attached_sas_addr, phy->attached_sas_addr,
-                          SAS_ADDR_SIZE) == 0)
+                          SAS_ADDR_SIZE) != 0)
                else {
                        SAS_DPRINTK("%s: phy%d belongs to port%d 
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at

Reply via email to