Commit:     efc47135e4b6f7e7d81332f50ef68e4a42819d20
Parent:     2869b23e4b95cbafffcd2fe110d77aff8c218405
Author:     Jiri Kosina <[EMAIL PROTECTED]>
AuthorDate: Mon Feb 12 00:52:35 2007 -0800
Committer:  Linus Torvalds <[EMAIL PROTECTED]>
CommitDate: Mon Feb 12 09:48:30 2007 -0800

    [PATCH] DS1302: local_irq_disable() is redundant after local_irq_save()
    drivers/char/ds1302.c::get_rtc_time() contains local_irq_disable() call
    after local_irq_save(). This looks redundant.
    drivers/char/ds1302.c::rtc_ioctl() contains local_irq_disable() call after
    local_irq_save(). This looks redundant.
    Signed-off-by: Jiri Kosina <[EMAIL PROTECTED]>
    Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
    Signed-off-by: Linus Torvalds <[EMAIL PROTECTED]>
 drivers/char/ds1302.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/drivers/char/ds1302.c b/drivers/char/ds1302.c
index bcdb107..fada6dd 100644
--- a/drivers/char/ds1302.c
+++ b/drivers/char/ds1302.c
@@ -120,7 +120,6 @@ get_rtc_time(struct rtc_time *rtc_tm)
        unsigned long flags;
-       local_irq_disable();
        rtc_tm->tm_sec = CMOS_READ(RTC_SECONDS);
        rtc_tm->tm_min = CMOS_READ(RTC_MINUTES);
@@ -219,7 +218,6 @@ rtc_ioctl(struct inode *inode, struct file *file, unsigned 
int cmd,
-                       local_irq_disable();
                        CMOS_WRITE(yrs, RTC_YEAR);
                        CMOS_WRITE(mon, RTC_MONTH);
                        CMOS_WRITE(day, RTC_DAY_OF_MONTH);
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at

Reply via email to