Gitweb:     
http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=c7eb734766217b9ddac217cbccae3aedcfa67520
Commit:     c7eb734766217b9ddac217cbccae3aedcfa67520
Parent:     bcb63e25ed3c56ee40cca4d18fbaac1d2a40c1d6
Author:     Maynard Johnson <[EMAIL PROTECTED]>
AuthorDate: Tue Feb 13 22:02:03 2007 +0100
Committer:  Arnd Bergmann <[EMAIL PROTECTED]>
CommitDate: Tue Feb 13 22:03:07 2007 +0100

    [POWERPC] cell: pm_rtas_activat_signals routine cleanup
    
    The code was setting up the debug bus for group 21 when profiling on the
    event PPU CYCLES.  The debug bus is not actually used by the hardware
    performance counters when counting PPU CYCLES.  Setting up the debug bus
    for PPU CYCLES causes signal routing conflicts on the debug bus when
    profiling PPU cycles and another PPU event.  This patch fixes the code to
    only setup the debug bus to route the performance signals for the non
    PPU CYCLE events.
    
    Signed-off-by: Maynard Johnson <[EMAIL PROTECTED]>
    Signed-off-by: Carl Love <[EMAIL PROTECTED]>
    Signed-off-by: Arnd Bergmann <[EMAIL PROTECTED]>
---
 arch/powerpc/oprofile/op_model_cell.c |   49 ++++++++++++++++++++++-----------
 1 files changed, 33 insertions(+), 16 deletions(-)

diff --git a/arch/powerpc/oprofile/op_model_cell.c 
b/arch/powerpc/oprofile/op_model_cell.c
index 8d4a958..e08e1d7 100644
--- a/arch/powerpc/oprofile/op_model_cell.c
+++ b/arch/powerpc/oprofile/op_model_cell.c
@@ -39,6 +39,9 @@
 #include "../platforms/cell/interrupt.h"
 
 #define PPU_CYCLES_EVENT_NUM 1 /*  event number for CYCLES */
+#define PPU_CYCLES_GRP_NUM   1  /* special group number for identifying
+                                 * PPU_CYCLES event
+                                 */
 #define CBE_COUNT_ALL_CYCLES 0x42800000        /* PPU cycle event specifier */
 
 #define NUM_THREADS 2         /* number of physical threads in
@@ -62,7 +65,7 @@ struct pmc_cntrl_data {
 struct pm_signal {
        u16 cpu;                /* Processor to modify */
        u16 sub_unit;           /* hw subunit this applies to (if applicable) */
-       u16 signal_group;       /* Signal Group to Enable/Disable */
+       short int signal_group; /* Signal Group to Enable/Disable */
        u8 bus_word;            /* Enable/Disable on this Trace/Trigger/Event
                                 * Bus Word(s) (bitmask)
                                 */
@@ -179,26 +182,40 @@ static void pm_rtas_reset_signals(u32 node)
 static void pm_rtas_activate_signals(u32 node, u32 count)
 {
        int ret;
-       int j;
+       int i, j;
        struct pm_signal pm_signal_local[NR_PHYS_CTRS];
 
+       /* There is no debug setup required for the cycles event.
+        * Note that only events in the same group can be used.
+        * Otherwise, there will be conflicts in correctly routing
+        * the signals on the debug bus.  It is the responsiblity
+        * of the OProfile user tool to check the events are in
+        * the same group.
+        */
+       i = 0;
        for (j = 0; j < count; j++) {
-               /* fw expects physical cpu # */
-               pm_signal_local[j].cpu = node;
-               pm_signal_local[j].signal_group
-                       = pm_signal[j].signal_group;
-               pm_signal_local[j].bus_word = pm_signal[j].bus_word;
-               pm_signal_local[j].sub_unit = pm_signal[j].sub_unit;
-               pm_signal_local[j].bit = pm_signal[j].bit;
+               if (pm_signal[j].signal_group != PPU_CYCLES_GRP_NUM) {
+
+                       /* fw expects physical cpu # */
+                       pm_signal_local[i].cpu = node;
+                       pm_signal_local[i].signal_group
+                               = pm_signal[j].signal_group;
+                       pm_signal_local[i].bus_word = pm_signal[j].bus_word;
+                       pm_signal_local[i].sub_unit = pm_signal[j].sub_unit;
+                       pm_signal_local[i].bit = pm_signal[j].bit;
+                       i++;
+               }
        }
 
-       ret = rtas_ibm_cbe_perftools(SUBFUNC_ACTIVATE, PASSTHRU_ENABLE,
-                                    pm_signal_local,
-                                    count * sizeof(struct pm_signal));
+       if (i != 0) {
+               ret = rtas_ibm_cbe_perftools(SUBFUNC_ACTIVATE, PASSTHRU_ENABLE,
+                                            pm_signal_local,
+                                            i * sizeof(struct pm_signal));
 
-       if (ret)
-               printk(KERN_WARNING "%s: rtas returned: %d\n",
-                      __FUNCTION__, ret);
+               if (ret)
+                       printk(KERN_WARNING "%s: rtas returned: %d\n",
+                              __FUNCTION__, ret);
+       }
 }
 
 /*
@@ -215,7 +232,7 @@ static void set_pm_event(u32 ctr, int event, u32 unit_mask)
                /* Special Event: Count all cpu cycles */
                pm_regs.pm07_cntrl[ctr] = CBE_COUNT_ALL_CYCLES;
                p = &(pm_signal[ctr]);
-               p->signal_group = 21;
+               p->signal_group = PPU_CYCLES_GRP_NUM;
                p->bus_word = 1;
                p->sub_unit = 0;
                p->bit = 0;
-
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to