Commit:     4b998d4f6e559fb8eba8141263b2fddc9556391b
Parent:     208367eeec8d6f6fcee1a0672af2149aeee7b658
Author:     Eric W. Biederman <[EMAIL PROTECTED]>
AuthorDate: Wed Feb 14 00:33:35 2007 -0800
Committer:  Linus Torvalds <[EMAIL PROTECTED]>
CommitDate: Wed Feb 14 08:09:56 2007 -0800

    [PATCH] sysctl: cdrom: don't set de->owner
    There is no need for open files in /proc/sys/XXX to hold a reference count 
    the module that provides the file to prevent module unload races.  While 
    is code active in the module p->used in the sysctl_table_header is
    incremented, preventing the sysctl from being unregisted.  Once the sysctl 
    unregistered it cannot be found.  Open files are also not a problem as they
    revalidate the sysctl information and bump p->used before accessing module
    So setting de->owner is unnecessary, makes for a bad example and gets in my
    way of removing ctl_table->de.
    Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]>
    Acked-by: Jens Axboe <[EMAIL PROTECTED]>
    Acked-by: James Bottomley <[EMAIL PROTECTED]>
    Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
    Signed-off-by: Linus Torvalds <[EMAIL PROTECTED]>
 drivers/cdrom/cdrom.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/drivers/cdrom/cdrom.c b/drivers/cdrom/cdrom.c
index f0a6801..14f72c4 100644
--- a/drivers/cdrom/cdrom.c
+++ b/drivers/cdrom/cdrom.c
@@ -3554,8 +3554,6 @@ static void cdrom_sysctl_register(void)
        cdrom_sysctl_header = register_sysctl_table(cdrom_root_table, 0);
-       if (cdrom_root_table->ctl_name && cdrom_root_table->child->de)
-               cdrom_root_table->child->de->owner = THIS_MODULE;
        /* set the defaults */
        cdrom_sysctl_settings.autoclose = autoclose;
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at

Reply via email to