Gitweb:     
http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=88dacbe961aa63fa880b4f6f16515427f61fc3ca
Commit:     88dacbe961aa63fa880b4f6f16515427f61fc3ca
Parent:     8a03d9a498eaf02c8a118752050a5154852c13bf
Author:     Willy Tarreau <[EMAIL PROTECTED]>
AuthorDate: Sat Feb 17 18:57:09 2007 +0100
Committer:  Adrian Bunk <[EMAIL PROTECTED]>
CommitDate: Sat Feb 17 18:57:09 2007 +0100

    rio: typo in bitwise AND expression.
    
    The line :
    
        hp->Mode &= !RIO_PCI_INT_ENABLE;
    
    is obviously wrong as RIO_PCI_INT_ENABLE=0x04 and is used as a bitmask
    2 lines before. Getting no IRQ would not disable RIO_PCI_INT_ENABLE
    but rather RIO_PCI_BOOT_FROM_RAM which equals 0x01.
    
    Obvious fix is to change ! for ~.
    
    Signed-off-by: Willy Tarreau <[EMAIL PROTECTED]>
    Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
 drivers/char/rio/rio_linux.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/char/rio/rio_linux.c b/drivers/char/rio/rio_linux.c
index 85c1618..294e9cb 100644
--- a/drivers/char/rio/rio_linux.c
+++ b/drivers/char/rio/rio_linux.c
@@ -1146,7 +1146,7 @@ static int __init rio_init(void)
                                rio_dprintk(RIO_DEBUG_INIT, "Enabling 
interrupts on rio card.\n");
                                hp->Mode |= RIO_PCI_INT_ENABLE;
                        } else
-                               hp->Mode &= !RIO_PCI_INT_ENABLE;
+                               hp->Mode &= ~RIO_PCI_INT_ENABLE;
                        rio_dprintk(RIO_DEBUG_INIT, "New Mode: %x\n", hp->Mode);
                        rio_start_card_running(hp);
                }
-
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to