Commit:     6548cda289b549ed60c35f16a0051609aeee2fd0
Parent:     aa6e4a96e7589948fe770744f7bb4f0f743dddaa
Author:     Stephen Hemminger <[EMAIL PROTECTED]>
AuthorDate: Tue Feb 27 09:55:07 2007 -0800
Committer:  David S. Miller <[EMAIL PROTECTED]>
CommitDate: Wed Feb 28 09:42:12 2007 -0800

    [BRIDGE]: Fix locking of set path cost.
    This change goes with earlier change to get rid of
    work queue for path cost. Now stp_set_path_cost does its own
    locking. This is to allow it to call br_path_cost() which calls
    ethtool interfaces (might sleep).
    Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
    Signed-off-by: David S. Miller <[EMAIL PROTECTED]>
 net/bridge/br_ioctl.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/net/bridge/br_ioctl.c b/net/bridge/br_ioctl.c
index 3ab153d..147015f 100644
--- a/net/bridge/br_ioctl.c
+++ b/net/bridge/br_ioctl.c
@@ -291,12 +291,11 @@ static int old_dev_ioctl(struct net_device *dev, struct 
ifreq *rq, int cmd)
                if (!capable(CAP_NET_ADMIN))
                        return -EPERM;
-               spin_lock_bh(&br->lock);
                if ((p = br_get_port(br, args[1])) == NULL)
                        ret = -EINVAL;
                        br_stp_set_path_cost(p, args[2]);
-               spin_unlock_bh(&br->lock);
                return ret;
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at

Reply via email to