Gitweb:     
http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=7ab876703dcbe852652db6441f0aadb3d6b75e94
Commit:     7ab876703dcbe852652db6441f0aadb3d6b75e94
Parent:     c4c31fe0e2298529afa1357ebd9dad54b44c4e19
Author:     David S. Miller <[EMAIL PROTECTED]>
AuthorDate: Thu Mar 1 18:29:14 2007 -0800
Committer:  David S. Miller <[EMAIL PROTECTED]>
CommitDate: Fri Mar 2 15:22:54 2007 -0800

    [RADEON]: Fix blanking return value.
    
    If you'll recall, over a year ago, I pointed out that the current
    Radeon driver erroneously returns -EINVAL for valid blanking codes,
    here is a link to that thread:
    
        http://lkml.org/lkml/2006/1/28/6
    
    No other driver does this, and it confuses the X server into thinking
    that the device does not support blanking properly.
    
    I looked again and there is simply no reason for the Radeon driver to
    return -EINVAL for FB_BLANK_NORMAL.  It claims it wants to do this in
    order to convince fbcon to blank in software, right here:
    
                        if (fb_blank(info, blank))
                                fbcon_generic_blank(vc, info, blank);
    
    to software blank the screen.  But it only causes that to happen
    in the FB_BLANK_NORMAL case.
    
    That makes no sense because the Radeon code does this:
    
                val |= CRTC_DISPLAY_DIS;
    
    in the FB_BLANK_NORMAL case so should be blanking the hardware, and
    there is therefore no reason to SW blank by returning -EINVAL.
    
    Signed-off-by: David S. Miller <[EMAIL PROTECTED]>
    Acked-by: Antonino Daplas <[EMAIL PROTECTED]>
---
 drivers/video/aty/radeon_base.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/drivers/video/aty/radeon_base.c b/drivers/video/aty/radeon_base.c
index 7e228ad..46ba123 100644
--- a/drivers/video/aty/radeon_base.c
+++ b/drivers/video/aty/radeon_base.c
@@ -1026,8 +1026,7 @@ int radeon_screen_blank(struct radeonfb_info *rinfo, int 
blank, int mode_switch)
                break;
        }
 
-       /* let fbcon do a soft blank for us */
-       return (blank == FB_BLANK_NORMAL) ? -EINVAL : 0;
+       return 0;
 }
 
 static int radeonfb_blank (int blank, struct fb_info *info)
-
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to