Commit:     d108d4fe34730135647fe32a4f8091491d3542ea
Parent:     47a80edb1d80ae644ea374a016c8e68d43d2671f
Author:     Jiri Kosina <[EMAIL PROTECTED]>
AuthorDate: Sat Mar 10 22:45:45 2007 +0100
Committer:  Jiri Kosina <[EMAIL PROTECTED]>
CommitDate: Mon Mar 12 14:55:26 2007 +0100

    HID: zeroing of bytes in output fields is bogus
    This patch removes bogus zeroing of unused bits in output reports,
    introduced in Simon's patch in commit d4ae650a.
    According to the specification, any sane device should not care
    about values of unused bits.
    What is worse, the zeroing is done in a way which is broken and
    might clear certain bits in output reports which are actually
    _used_ - a device that has multiple fields with one value of
    the size 1 bit each might serve as an example of why this is
    bogus - the second call of hid_output_report() would clear the
    first bit of report, which has already been set up previously.
    This patch will break LEDs on SpaceNavigator, because this device
    is broken and takes into account the bits which it shouldn't touch.
    The quirk for this particular device will be provided in a separate
    Signed-off-by: Jiri Kosina <[EMAIL PROTECTED]>
 drivers/hid/hid-core.c |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
index e5894a7..d28d76d 100644
--- a/drivers/hid/hid-core.c
+++ b/drivers/hid/hid-core.c
@@ -875,10 +875,6 @@ static void hid_output_field(struct hid_field *field, __u8 
        unsigned size = field->report_size;
        unsigned n;
-       /* make sure the unused bits in the last byte are zeros */
-       if (count > 0 && size > 0)
-               data[(offset+count*size-1)/8] = 0;
        for (n = 0; n < count; n++) {
                if (field->logical_minimum < 0) /* signed values */
                        implement(data, offset + n * size, size, 
s32ton(field->value[n], size));
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at

Reply via email to