Commit:     6c912a3d3356e5e51917941ce8505531c6fab003
Parent:     d1cabd63262707ad5d6bb730f25b7a2852734595
Author:     Arnaud Patard (Rtp <[EMAIL PROTECTED]>
AuthorDate: Fri Mar 16 13:38:36 2007 -0800
Committer:  Linus Torvalds <[EMAIL PROTECTED]>
CommitDate: Fri Mar 16 19:25:06 2007 -0700

    [PATCH] spi_s3c24xx.c: warning fix
    The set_cs field of struct s3c24xx_spi is declared as returning a int but
    the value returned but set_cs is never fixed.  Moreover, the default
    function for set_cs and the set_cs defintion in the platform data are
    returning void.
    I'm proposing to change the prototype to void (*set_cs)(...). By doing
    this, I'm also fixing 2 build warnings:
      drivers/spi/spi_s3c24xx.c: In function 's3c24xx_spi_probe':
      drivers/spi/spi_s3c24xx.c:330: warning: assignment from incompatible 
pointer type
      drivers/spi/spi_s3c24xx.c:335: warning: assignment from incompatible 
pointer type
    Signed-off-by: Arnaud Patard <[EMAIL PROTECTED]>
    Signed-off-by: David Brownell <[EMAIL PROTECTED]>
    Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
    Signed-off-by: Linus Torvalds <[EMAIL PROTECTED]>
 drivers/spi/spi_s3c24xx.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/spi/spi_s3c24xx.c b/drivers/spi/spi_s3c24xx.c
index 651379c..220abce 100644
--- a/drivers/spi/spi_s3c24xx.c
+++ b/drivers/spi/spi_s3c24xx.c
@@ -41,7 +41,7 @@ struct s3c24xx_spi {
        int                      len;
        int                      count;
-       int                     (*set_cs)(struct s3c2410_spi_info *spi,
+       void                    (*set_cs)(struct s3c2410_spi_info *spi,
                                          int cs, int pol);
        /* data buffers */
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at

Reply via email to