Commit:     4edc5db83f574dfcc8be35b7b96760ded543b360
Parent:     9c35dd7f8bda1849dcb430be99325504221048df
Author:     Ingo Molnar <[EMAIL PROTECTED]>
AuthorDate: Thu Mar 22 10:31:19 2007 +0100
Committer:  Linus Torvalds <[EMAIL PROTECTED]>
CommitDate: Thu Mar 22 19:42:31 2007 -0700

    [PATCH] setup_boot_APIC_clock() irq-enable fix
    latest -git triggers an irqtrace/lockdep warning of a leaked
    irqs-off condition:
      BUG: at kernel/fork.c:1033 copy_process()
    after some debugging it turns out that commit ca1b940c accidentally left
    interrupts disabled - which trickled down all the way to the first time
    we fork a kernel thread and triggered the warning.
    the fix is to re-enable interrupts in the 'else' branch of
    setup_boot_APIC_clock()'s pmtimers calibration path.
    Reported-by: Michal Piotrowski <[EMAIL PROTECTED]>
    Signed-off-by: Ingo Molnar <[EMAIL PROTECTED]>
    Acked-by: Thomas Gleixner <[EMAIL PROTECTED]>
    Signed-off-by: Linus Torvalds <[EMAIL PROTECTED]>
 arch/i386/kernel/apic.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/arch/i386/kernel/apic.c b/arch/i386/kernel/apic.c
index 3682511..244c3fe 100644
--- a/arch/i386/kernel/apic.c
+++ b/arch/i386/kernel/apic.c
@@ -506,7 +506,8 @@ void __init setup_boot_APIC_clock(void)
                        apic_printk(APIC_VERBOSE, "... jiffies result ok\n");
                        local_apic_timer_verify_ok = 0;
-       }
+       } else
+               local_irq_enable();
        if (!local_apic_timer_verify_ok) {
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at

Reply via email to