Gitweb:     
http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=14e9d5730adfca26452b3a2838a80af6950556f5
Commit:     14e9d5730adfca26452b3a2838a80af6950556f5
Parent:     c97beb4710bc673867207d7d729f2ace4ca1f197
Author:     Eric W. Biederman <[EMAIL PROTECTED]>
AuthorDate: Wed Mar 28 23:38:16 2007 -0600
Committer:  Linus Torvalds <[EMAIL PROTECTED]>
CommitDate: Thu Mar 29 08:16:23 2007 -0700

    [PATCH] pid: Properly detect orphaned process groups in exit_notify
    
    In commit 0475ac0845f9295bc5f69af45f58dff2c104c8d1 when converting the
    orphaned process group handling to use struct pid I made a small
    mistake.  I accidentally replaced an == with a !=.
    
    Besides just being a dumb thing to do apparently this has a bad side
    effect.  The improper orphaned process group detection causes kwin to
    die after a suspend/resume cycle.
    
    I'm amazed this patch has been around as long as it has without anyone
    else noticing something funny going on.
    
    And the following people deserve credit for spotting and helping
    to reproduce this.
    
    Thanks to: Sid Boyce <[EMAIL PROTECTED]>
    Thanks to: "Michael Wu"
    
    Signed-off-by: "Eric W. Biederman" <[EMAIL PROTECTED]>
    Signed-off-by: Linus Torvalds <[EMAIL PROTECTED]>
---
 kernel/exit.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/kernel/exit.c b/kernel/exit.c
index f132349..b55ed4c 100644
--- a/kernel/exit.c
+++ b/kernel/exit.c
@@ -790,7 +790,7 @@ static void exit_notify(struct task_struct *tsk)
        
        pgrp = task_pgrp(tsk);
        if ((task_pgrp(t) != pgrp) &&
-           (task_session(t) != task_session(tsk)) &&
+           (task_session(t) == task_session(tsk)) &&
            will_become_orphaned_pgrp(pgrp, tsk) &&
            has_stopped_jobs(pgrp)) {
                __kill_pgrp_info(SIGHUP, SEND_SIG_PRIV, pgrp);
-
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to