Commit:     8cc574a3c5cea70229f243a6b57fd69e60491d82
Parent:     d80f0a4beb15d817bfbb18a29e5ffc1d9dc353ea
Author:     David S. Miller <[EMAIL PROTECTED]>
AuthorDate: Mon Apr 2 14:21:55 2007 -0700
Committer:  David S. Miller <[EMAIL PROTECTED]>
CommitDate: Mon Apr 2 14:26:22 2007 -0700

    [SCSI]: Fix scsi_send_eh_cmnd scatterlist handling
    This fixes a regression caused by commit:
    The sense buffer code in scsi_send_eh_cmnd was changed to use
    alloc_page() and a scatter list, but the sense data copy was not
    updated to match so what we actually get in the sense buffer is total
    grabage starting with the kernel address of the struct page we got.
    Basically the stack frame of scsi_send_eh_cmd() is what ends up
    in the sense buffer.
    Depending upon how pointers look on a given platform, you can
    end up getting sr_ioctl.c errors when you mount a cdrom.  If
    the CDROM gives a check condition for GPCMD_GET_CONFIGURATION issued
    by drivers/cdrom/cdrom.c:cdrom_mmc_profile(), sr_ioctl will
    spit out this error message in sr_do_ioctl() with the way pointers
    are on sparc64:
                        printk(KERN_ERR "%s: CDROM (ioctl) error, command: ", 
                        scsi_print_sense_hdr("sr", &sshdr);
                        err = -EIO;
    This is the error Tom Callaway reported in:
    Anyways, fix this by using page_address( which is OK
    because we know this is low-mem due to GFP_ATOMIC.
    Signed-off-by: David S. Miller <[EMAIL PROTECTED]>
    Acked-by: Christoph Hellwig <[EMAIL PROTECTED]>
 drivers/scsi/scsi_error.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c
index b8edcf5..918bb60 100644
--- a/drivers/scsi/scsi_error.c
+++ b/drivers/scsi/scsi_error.c
@@ -716,7 +716,7 @@ static int scsi_send_eh_cmnd(struct scsi_cmnd *scmd, 
unsigned char *cmnd,
        if (copy_sense) {
                if (!SCSI_SENSE_VALID(scmd)) {
-                       memcpy(scmd->sense_buffer, scmd->request_buffer,
+                       memcpy(scmd->sense_buffer, page_address(,
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at

Reply via email to