Commit:     50c9cc2e540aeaab78ab548a8d42568977c6844f
Parent:     15d33c070ddde99f7368e6b17b71d22c866f97d9
Author:     Jaroslav Kysela <[EMAIL PROTECTED]>
AuthorDate: Tue Apr 10 13:26:48 2007 -0700
Committer:  David S. Miller <[EMAIL PROTECTED]>
CommitDate: Tue Apr 10 13:26:48 2007 -0700

    [NETFILTER]: ipt_CLUSTERIP: fix oops in checkentry function
    The clusterip_config_find_get() already increases entries reference
    counter, so there is no reason to do it twice in checkentry() callback.
    This causes the config to be freed before it is removed from the list,
    resulting in a crash when adding the next rule.
    Signed-off-by: Jaroslav Kysela <[EMAIL PROTECTED]>
    Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]>
    Signed-off-by: David S. Miller <[EMAIL PROTECTED]>
 net/ipv4/netfilter/ipt_CLUSTERIP.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/net/ipv4/netfilter/ipt_CLUSTERIP.c 
index e965b33..42b0802 100644
--- a/net/ipv4/netfilter/ipt_CLUSTERIP.c
+++ b/net/ipv4/netfilter/ipt_CLUSTERIP.c
@@ -411,12 +411,10 @@ checkentry(const char *tablename,
                                       "has invalid config pointer!\n");
                                return 0;
-                       clusterip_config_entry_get(cipinfo->config);
                } else {
                        /* Case B: This is a new rule referring to an existing
                         * clusterip config. */
                        cipinfo->config = config;
-                       clusterip_config_entry_get(cipinfo->config);
        } else {
                /* Case C: This is a completely new clusterip config */
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at

Reply via email to