Commit:     98486fa2f4894e2b01e325c659635596bdec1614
Parent:     c2886d6259b8faac4c05ffd9c3c401ac84478de0
Author:     Stephen Hemminger <[EMAIL PROTECTED]>
AuthorDate: Wed Apr 25 22:08:46 2007 -0700
Committer:  David S. Miller <[EMAIL PROTECTED]>
CommitDate: Wed Apr 25 22:30:04 2007 -0700

    [BRIDGE]: Missing rtnl.
    Writing to /sys/class/net/brX/bridge/stp_state causes a warning because
    RTNL is not held when call br_stp_if.c
    Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
    Signed-off-by: David S. Miller <[EMAIL PROTECTED]>
 net/bridge/br_sysfs_br.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/net/bridge/br_sysfs_br.c b/net/bridge/br_sysfs_br.c
index 7ec0b76..33c6c4a 100644
--- a/net/bridge/br_sysfs_br.c
+++ b/net/bridge/br_sysfs_br.c
@@ -149,9 +149,11 @@ static ssize_t show_stp_state(struct device *d,
 static void set_stp_state(struct net_bridge *br, unsigned long val)
+       rtnl_lock();
        br_stp_set_enabled(br, val);
+       rtnl_unlock();
 static ssize_t store_stp_state(struct device *d,
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at

Reply via email to