Gitweb:     
http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=39bc89fd4019b164002adaacef92c4140e37955a
Commit:     39bc89fd4019b164002adaacef92c4140e37955a
Parent:     20f09390b2da2432309afe8aaa0bd64ec64c4584
Author:     Ingo Molnar <[EMAIL PROTECTED]>
AuthorDate: Wed Apr 25 20:50:03 2007 -0700
Committer:  Linus Torvalds <[EMAIL PROTECTED]>
CommitDate: Fri Apr 27 10:46:51 2007 -0700

    make SysRq-T show all tasks again
    
    show_state() (SysRq-T) developed the buggy habbit of not showing
    TASK_RUNNING tasks.  This was due to the mistaken belief that state_filter
    == -1 would be a pass-through filter - while in reality it did not let
    TASK_RUNNING == 0 p->state values through.
    
    Fix this by restoring the original '!state_filter means all tasks'
    special-case i had in the original version.  Test-built and test-booted on
    i686, SysRq-T now works as intended.
    
    Signed-off-by: Ingo Molnar <[EMAIL PROTECTED]>
    Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
    Signed-off-by: Linus Torvalds <[EMAIL PROTECTED]>
---
 include/linux/sched.h |    4 ++--
 kernel/sched.c        |    2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/include/linux/sched.h b/include/linux/sched.h
index 49fe299..a170758 100644
--- a/include/linux/sched.h
+++ b/include/linux/sched.h
@@ -196,13 +196,13 @@ extern void init_idle(struct task_struct *idle, int cpu);
 extern cpumask_t nohz_cpu_mask;
 
 /*
- * Only dump TASK_* tasks. (-1 for all tasks)
+ * Only dump TASK_* tasks. (0 for all tasks)
  */
 extern void show_state_filter(unsigned long state_filter);
 
 static inline void show_state(void)
 {
-       show_state_filter(-1);
+       show_state_filter(0);
 }
 
 extern void show_regs(struct pt_regs *);
diff --git a/kernel/sched.c b/kernel/sched.c
index b9a6837..960d7c5 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -4746,7 +4746,7 @@ void show_state_filter(unsigned long state_filter)
                 * console might take alot of time:
                 */
                touch_nmi_watchdog();
-               if (p->state & state_filter)
+               if (!state_filter || (p->state & state_filter))
                        show_task(p);
        } while_each_thread(g, p);
 
-
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to