Gitweb: http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=1b0b3b9980e482ab7c603430462538334f69f14a Commit: 1b0b3b9980e482ab7c603430462538334f69f14a Parent: 74e9f5fa1570f956c96dd5d3f1053daedbbf01a0 Author: Oliver Neukum <[EMAIL PROTECTED]> AuthorDate: Mon Apr 2 14:47:59 2007 +0200 Committer: Greg Kroah-Hartman <[EMAIL PROTECTED]> CommitDate: Fri Apr 27 10:57:29 2007 -0700
kref: fix CPU ordering with respect to krefs some atomic operations are only atomic, not ordered. Thus a CPU is allowed to reorder memory references to an object to before the reference is obtained. This fixes it. Signed-off-by: Oliver Neukum <[EMAIL PROTECTED]> Signed-off-by: Greg Kroah-Hartman <[EMAIL PROTECTED]> --- lib/kref.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/lib/kref.c b/lib/kref.c index 0d07cc3..a6dc3ec 100644 --- a/lib/kref.c +++ b/lib/kref.c @@ -21,6 +21,7 @@ void kref_init(struct kref *kref) { atomic_set(&kref->refcount,1); + smp_mb(); } /** @@ -31,6 +32,7 @@ void kref_get(struct kref *kref) { WARN_ON(!atomic_read(&kref->refcount)); atomic_inc(&kref->refcount); + smp_mb__after_atomic_inc(); } /** - To unsubscribe from this list: send the line "unsubscribe git-commits-head" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html