Gitweb:     
http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=c94ccf9e3389ff55078a049bfe59b82f854436e8
Commit:     c94ccf9e3389ff55078a049bfe59b82f854436e8
Parent:     a1c6250cb60a52a7f799610f9a4b1f4e8671175f
Author:     Stefan Richter <[EMAIL PROTECTED]>
AuthorDate: Wed Mar 14 00:27:46 2007 +0100
Committer:  Stefan Richter <[EMAIL PROTECTED]>
CommitDate: Mon Apr 30 00:00:29 2007 +0200

    ieee1394: csr1212: warn on unreachable code
    
    We want bugs to show themselves.
    
    Signed-off-by: Stefan Richter <[EMAIL PROTECTED]>
---
 drivers/ieee1394/csr1212.c |    7 +++++--
 1 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/ieee1394/csr1212.c b/drivers/ieee1394/csr1212.c
index 63bf11e..3c044fc 100644
--- a/drivers/ieee1394/csr1212.c
+++ b/drivers/ieee1394/csr1212.c
@@ -772,6 +772,7 @@ csr1212_generate_positions(struct csr1212_csr_rom_cache 
*cache,
 
                default:
                        /* Should never get here */
+                       WARN_ON(1);
                        break;
                }
 
@@ -852,7 +853,8 @@ csr1212_generate_tree_subdir(struct csr1212_keyval *dir, 
u32 *data_buffer)
                                break;
                        default:
                                /* Should never get here */
-                               break; /* GDB breakpoint */
+                               WARN_ON(1);
+                               break;
                        }
 
                        value |= (a->key.id & CSR1212_KV_KEY_ID_MASK) <<
@@ -889,7 +891,8 @@ static void csr1212_fill_cache(struct csr1212_csr_rom_cache 
*cache)
                case CSR1212_KV_TYPE_IMMEDIATE:
                case CSR1212_KV_TYPE_CSR_OFFSET:
                        /* Should never get here */
-                       break; /* GDB breakpoint */
+                       WARN_ON(1);
+                       break;
 
                case CSR1212_KV_TYPE_LEAF:
                        /* Don't copy over Extended ROM areas, they are
-
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to