Commit:     e70ea2634afe7d04ffaf7417df7bfdbfdc460e10
Parent:     da65944be2441191539f50ce71cd1f8030699be1
Author:     Linas Vepstas <[EMAIL PROTECTED]>
AuthorDate: Fri Apr 13 15:34:23 2007 -0700
Committer:  Greg Kroah-Hartman <[EMAIL PROTECTED]>
CommitDate: Wed May 2 19:02:40 2007 -0700

    PCI: rpaphp: Use pcibios_remove_pci_devices() symmetrically
    At first blush, the disable_slot() routine does not look
    at all like its symmetric with the enable_slot() routine;
    as it seems to call a very different set of routines.
    However, this is easily fixed: pcibios_remove_pci_devices()
    does the right thing.
    Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]>
    Cc: John Rose <[EMAIL PROTECTED]>
    Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTECTED]>
    Signed-off-by: Greg Kroah-Hartman <[EMAIL PROTECTED]>
 drivers/pci/hotplug/rpaphp_core.c |   10 ++--------
 1 files changed, 2 insertions(+), 8 deletions(-)

diff --git a/drivers/pci/hotplug/rpaphp_core.c 
index aa8d9a6..4efdaa1 100644
--- a/drivers/pci/hotplug/rpaphp_core.c
+++ b/drivers/pci/hotplug/rpaphp_core.c
@@ -424,18 +424,12 @@ static int enable_slot(struct hotplug_slot *hotplug_slot)
        return retval;
-static int __disable_slot(struct slot *slot)
+static inline int __disable_slot(struct slot *slot)
-       struct pci_dev *dev, *tmp;
        if (slot->state == NOT_CONFIGURED)
                return -EINVAL;
-       list_for_each_entry_safe(dev, tmp, &slot->bus->devices, bus_list) {
-               eeh_remove_bus_device(dev);
-               pci_remove_bus_device(dev);
-       }
+       pcibios_remove_pci_devices(slot->bus);
        slot->state = NOT_CONFIGURED;
        return 0;
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at

Reply via email to