Gitweb:     
http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=eda890af7959a79ab10a7a8ae979dadcdba41c58
Commit:     eda890af7959a79ab10a7a8ae979dadcdba41c58
Parent:     9ae57004ca9c38ff8292c38a475c98b0ebbc0d74
Author:     Michael Ellerman <[EMAIL PROTECTED]>
AuthorDate: Mon Apr 30 15:34:15 2007 +1000
Committer:  Sam Ravnborg <[EMAIL PROTECTED]>
CommitDate: Wed May 2 20:58:11 2007 +0200

    kbuild: propagate errors from find in scripts/gen_initramfs_list.sh
    
    If the find(1) in scripts/gen_initramfs_list.sh generates any errors, it
    will cause gen_initramfs_list.sh to fail (because of "set -e"), however
    the errors from find are not printed to the user. This is rather confusing:
    
    ~/src/powerpc$ make O=~/build/powerpc-cell32/
    make[2]: *** [usr/initramfs_data.cpio.gz] Error 1
    make[1]: *** [usr] Error 2
    make[1]: *** Waiting for unfinished jobs....
    make[1]: *** wait: No child processes.  Stop.
    make: *** [_all] Error 2
    
    It is much easier to work out what the problem is if we let the errors
    from find hit the console, eg:
    
    ~/src/powerpc$ make O=~/build/powerpc-cell32/
    find: /home/michael/initramfs-source/home: Permission denied
    find: /home/michael/initramfs-source/lost+found: Permission denied
    find: /home/michael/initramfs-source/opt: Permission denied
    find: /home/michael/initramfs-source/root: Permission denied
    make[2]: *** [usr/initramfs_data.cpio.gz] Error 1
    make[1]: *** [usr] Error 2
    make[1]: *** Waiting for unfinished jobs....
    make[1]: *** wait: No child processes.  Stop.
    make: *** [_all] Error 2
    
    Signed-off-by: Michael Ellerman <[EMAIL PROTECTED]>
    Signed-off-by: Sam Ravnborg <[EMAIL PROTECTED]>
---
 scripts/gen_initramfs_list.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/scripts/gen_initramfs_list.sh b/scripts/gen_initramfs_list.sh
index 3111f4a..683eb12 100644
--- a/scripts/gen_initramfs_list.sh
+++ b/scripts/gen_initramfs_list.sh
@@ -171,7 +171,7 @@ dir_filelist() {
        ${dep_list}header "$1"
 
        srcdir=$(echo "$1" | sed -e 's://*:/:g')
-       dirlist=$(find "${srcdir}" -printf "%p %m %U %G\n" 2>/dev/null)
+       dirlist=$(find "${srcdir}" -printf "%p %m %U %G\n")
 
        # If $dirlist is only one line, then the directory is empty
        if [  "$(echo "${dirlist}" | wc -l)" -gt 1 ]; then
-
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to