Gitweb:     
http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=578c8183c116e623d53b05d4c79762d053c7090f
Commit:     578c8183c116e623d53b05d4c79762d053c7090f
Parent:     59cd0cbc75367b82f704f63b104117462275060d
Author:     Alexey Dobriyan <[EMAIL PROTECTED]>
AuthorDate: Tue May 8 00:25:49 2007 -0700
Committer:  Linus Torvalds <[EMAIL PROTECTED]>
CommitDate: Tue May 8 11:15:02 2007 -0700

    proc: remove pathetic ->deleted WARN_ON
    
    WARN_ON(de && de->deleted); is sooo unreliable. Why?
    
    proc_lookup                         remove_proc_entry
    ===========                         =================
    lock_kernel();
    spin_lock(&proc_subdir_lock);
    [find proc entry]
    spin_unlock(&proc_subdir_lock);
                                        spin_lock(&proc_subdir_lock);
                                        [find proc entry]
    
    proc_get_inode
    ==============
    WARN_ON(de && de->deleted);                 ...
    
                                        if (!atomic_read(&de->count))
                                                free_proc_entry(de);
                                        else
                                                de->deleted = 1;
    
    So, if you have some strange oops [1], and doesn't see this WARN_ON it means
    nothing.
    
    [1] try_module_get() of module which doesn't exist, two lines below
        should suffice, or not?
    
    Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]>
    Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
    Signed-off-by: Linus Torvalds <[EMAIL PROTECTED]>
---
 fs/proc/inode.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/fs/proc/inode.c b/fs/proc/inode.c
index d1de637..b817190 100644
--- a/fs/proc/inode.c
+++ b/fs/proc/inode.c
@@ -146,8 +146,6 @@ struct inode *proc_get_inode(struct super_block *sb, 
unsigned int ino,
 {
        struct inode * inode;
 
-       WARN_ON(de && de->deleted);
-
        if (de != NULL && !try_module_get(de->owner))
                goto out_mod;
 
-
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to