Commit:     ede8ca269f9f3e3fa4fb8561671f0699eefc32c5
Parent:     b7a6912969af7586ade62667d6d1c7ecc534faa1
Author:     Linas Vepstas <[EMAIL PROTECTED]>
AuthorDate: Wed May 9 09:33:29 2007 +1000
Committer:  Paul Mackerras <[EMAIL PROTECTED]>
CommitDate: Wed May 9 16:35:00 2007 +1000

    [POWERPC] EEH: log error only after driver notification.
    It turns out many/most versions of firmware enable MMIO when
    the slto-error-detail rtas call is made (in violation of the
    architecture). Thus, it would be best to call slot-error-detail
    only after notifying device drivers of a freeze, as otherwise,
    a variety of strange and unexpected things may happen.
    Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]>
    Signed-off-by: Paul Mackerras <[EMAIL PROTECTED]>
 arch/powerpc/platforms/pseries/eeh_driver.c |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/arch/powerpc/platforms/pseries/eeh_driver.c 
index 3170e00..e5b7635 100644
--- a/arch/powerpc/platforms/pseries/eeh_driver.c
+++ b/arch/powerpc/platforms/pseries/eeh_driver.c
@@ -361,7 +361,6 @@ struct pci_dn * handle_eeh_events (struct eeh_event *event)
                goto hard_fail;
-       eeh_slot_error_detail(frozen_pdn, 1 /* Temporary Error */);
           "EEH: This PCI device has failed %d times since last reboot: "
                "location=%s driver=%s pci addr=%s\n",
@@ -375,6 +374,11 @@ struct pci_dn * handle_eeh_events (struct eeh_event *event)
        pci_walk_bus(frozen_bus, eeh_report_error, &result);
+       /* Since rtas may enable MMIO when posting the error log,
+        * don't post the error log until after all dev drivers
+        * have been informed. */
+       eeh_slot_error_detail(frozen_pdn, 1 /* Temporary Error */);
        /* If all device drivers were EEH-unaware, then shut
         * down all of the device drivers, and hope they
         * go down willingly, without panicing the system.
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at

Reply via email to