Commit:     8ffcfd9d0dc735071379760c23317f15904f9056
Parent:     48be6b18336567a795bc41e4526f9adfb3a3d68e
Author:     Mikael Pettersson <[EMAIL PROTECTED]>
AuthorDate: Sun May 6 22:12:31 2007 +0200
Committer:  Jeff Garzik <[EMAIL PROTECTED]>
CommitDate: Wed May 9 20:15:46 2007 -0400

    sata_promise: fix another error decode regression
    The sata_promise error decode update changed pdc_host_intr()
    to return and not complete the qc after detecting an error.
    Unfortunately not completing the qc:s causes them to always
    time out on error, which is wrong and has nasty side-effects.
    This patch updates pdc_error_intr() to call ata_port_abort(),
    similar to ahci and sata_sil24. Doing this is important as it
    makes EH see the original error and not a bogus timeout.
    Signed-off-by: Mikael Pettersson <[EMAIL PROTECTED]>
    Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]>
 drivers/ata/sata_promise.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/drivers/ata/sata_promise.c b/drivers/ata/sata_promise.c
index f56549b..753402e 100644
--- a/drivers/ata/sata_promise.c
+++ b/drivers/ata/sata_promise.c
@@ -45,7 +45,7 @@
 #include "sata_promise.h"
 #define DRV_NAME       "sata_promise"
-#define DRV_VERSION    "2.05"
+#define DRV_VERSION    "2.06"
 enum {
@@ -653,6 +653,8 @@ static void pdc_error_intr(struct ata_port *ap, struct 
ata_queued_cmd *qc,
        qc->err_mask |= ac_err_mask;
+       ata_port_abort(ap);
 static inline unsigned int pdc_host_intr( struct ata_port *ap,
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at

Reply via email to