Commit:     0dd11f9be47188ce08543ef65e9ece9beb2027dc
Parent:     4eb527a0ca83de28e773371f42abad2ab1ed7fdf
Author:     Eric W. Biederman <[EMAIL PROTECTED]>
AuthorDate: Fri Jun 1 00:46:32 2007 -0700
Committer:  Linus Torvalds <[EMAIL PROTECTED]>
CommitDate: Fri Jun 1 08:18:27 2007 -0700

    msi: fix the ordering of msix irqs
    "Mike Miller (OS Dev)" <[EMAIL PROTECTED]> writes:
    Found what seems the problem with our vectors being listed backward.  In
    drivers/pci/msi.c we should be using list_add_tail rather than list_add to
    preserve the ordering across various kernels.  Please consider this for
    Signed-off-by: "Eric W. Biederman" <[EMAIL PROTECTED]>
    Screwed-up-by: Michael Ellerman <[EMAIL PROTECTED]>
    Cc: "Mike Miller (OS Dev)" <[EMAIL PROTECTED]>
    Cc: Andi Kleen <[EMAIL PROTECTED]>
    Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
    Signed-off-by: Linus Torvalds <[EMAIL PROTECTED]>
 drivers/pci/msi.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c
index f7f7470..61c46d6 100644
--- a/drivers/pci/msi.c
+++ b/drivers/pci/msi.c
@@ -333,7 +333,7 @@ static int msi_capability_init(struct pci_dev *dev)
                        msi_mask_bits_reg(pos, is_64bit_address(control)),
-       list_add(&entry->list, &dev->msi_list);
+       list_add_tail(&entry->list, &dev->msi_list);
        /* Configure MSI capability structure */
        ret = arch_setup_msi_irqs(dev, 1, PCI_CAP_ID_MSI);
@@ -404,7 +404,7 @@ static int msix_capability_init(struct pci_dev *dev,
                entry->dev = dev;
                entry->mask_base = base;
-               list_add(&entry->list, &dev->msi_list);
+               list_add_tail(&entry->list, &dev->msi_list);
        ret = arch_setup_msi_irqs(dev, nvec, PCI_CAP_ID_MSIX);
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at

Reply via email to