Gitweb:     
http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=88f5774b0748d6d9ebec7a39caae98c0d83b8cc8
Commit:     88f5774b0748d6d9ebec7a39caae98c0d83b8cc8
Parent:     f2f027c6e9912840020be8b78f037d5c8ac665e0
Author:     Bill Nottingham <[EMAIL PROTECTED]>
AuthorDate: Wed May 30 04:16:43 2007 -0400
Committer:  James Bottomley <[EMAIL PROTECTED]>
CommitDate: Wed May 30 10:15:32 2007 -0500

    [SCSI] qla2xxx: fix timeout in qla2x00_down_timeout
    
    iterations is unsigned, so it is impossible to get out of the loop
    and return -ETIMEDOUT.
    
    Signed-off-by: Bill Nottingham <[EMAIL PROTECTED]>
    Acked-by: Seokmann Ju <[EMAIL PROTECTED]>
    Signed-off-by: James Bottomley <[EMAIL PROTECTED]>
---
 drivers/scsi/qla2xxx/qla_os.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
index dd076da..b98136a 100644
--- a/drivers/scsi/qla2xxx/qla_os.c
+++ b/drivers/scsi/qla2xxx/qla_os.c
@@ -2590,7 +2590,7 @@ qla2x00_down_timeout(struct semaphore *sema, unsigned 
long timeout)
                        return 0;
                if (msleep_interruptible(step))
                        break;
-       } while (--iterations >= 0);
+       } while (--iterations > 0);
 
        return -ETIMEDOUT;
 }
-
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to