Commit:     fd209e35b74110ee1f3371838b0782b5b02eaaba
Parent:     da1f82b5543738d4c127a449490bc0d55e121fe8
Author:     Simon Arlott <[EMAIL PROTECTED]>
AuthorDate: Thu May 10 23:04:13 2007 -0700
Committer:  Greg Kroah-Hartman <[EMAIL PROTECTED]>
CommitDate: Fri Jun 8 16:24:31 2007 -0700

    USB: cxacru: ignore error trying to start ADSL in atm_start
    The sysfs adsl_status attribute ignores (aside from returning -EIO to the
    user) any error sending a START/STOP command to the device and there is at
    least one firmware which never sends a response but appears to work
    regardless.  Therefore atm_start should also continue if an error is 
    so that such firmware is usable.
    The official Conexant driver doesn't expect a reply either but this is for
    another device (E2 router) and a commonly used firmware does respond.
    Also, there is no point in changing -ECONNRESET to -ETIMEDOUT since nothing
    ever checks for either of these values.
    Signed-off-by: Simon Arlott <[EMAIL PROTECTED]>
    Cc: Duncan Sands <[EMAIL PROTECTED]>
    Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
    Signed-off-by: Greg Kroah-Hartman <[EMAIL PROTECTED]>
 drivers/usb/atm/cxacru.c |    7 +------
 1 files changed, 1 insertions(+), 6 deletions(-)

diff --git a/drivers/usb/atm/cxacru.c b/drivers/usb/atm/cxacru.c
index 68cf582..8bcf7fe 100644
--- a/drivers/usb/atm/cxacru.c
+++ b/drivers/usb/atm/cxacru.c
@@ -476,8 +476,6 @@ static int cxacru_start_wait_urb(struct urb *urb, struct 
completion *done,
        status = urb->status;
-       if (status == -ECONNRESET)
-               status = -ETIMEDOUT;
        if (actual_length)
@@ -671,11 +669,8 @@ static int cxacru_atm_start(struct usbatm_data 
        /* start ADSL */
        ret = cxacru_cm(instance, CM_REQUEST_CHIP_ADSL_LINE_START, NULL, 0, 
NULL, 0);
-       if (ret < 0) {
+       if (ret < 0)
                atm_err(usbatm_instance, "cxacru_atm_start: 
CHIP_ADSL_LINE_START returned %d\n", ret);
-               mutex_unlock(&instance->adsl_state_serialize);
-               return ret;
-       }
        /* Start status polling */
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at

Reply via email to