Gitweb:     
http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=e6985c7f6842fa040d058640e363140ad1730dc5
Commit:     e6985c7f6842fa040d058640e363140ad1730dc5
Parent:     f7f7c31c98830e5f4aa5486b8aabb7f3bf4a2512
Author:     Akinobu Mita <[EMAIL PROTECTED]>
AuthorDate: Mon Jun 4 16:14:59 2007 +0000
Committer:  Steve French <[EMAIL PROTECTED]>
CommitDate: Mon Jun 4 16:14:59 2007 +0000

    [CIFS] fix mempool destroy done in wrong order in cifs error path
    
    Slab cache used as memory pool can not be destroyed before the memory
    pool destruction. Because the memory pool still holds some objects and
    kmem_cache_destroy() says "Can't free all objects".
    
    Signed-off-by: Akinobu Mita <[EMAIL PROTECTED]>
    Signed-off-by: Steve French <[EMAIL PROTECTED]>
---
 fs/cifs/cifsfs.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/cifs/cifsfs.c b/fs/cifs/cifsfs.c
index d38c69b..7c04752 100644
--- a/fs/cifs/cifsfs.c
+++ b/fs/cifs/cifsfs.c
@@ -825,8 +825,8 @@ cifs_init_mids(void)
                                sizeof (struct oplock_q_entry), 0,
                                SLAB_HWCACHE_ALIGN, NULL, NULL);
        if (cifs_oplock_cachep == NULL) {
-               kmem_cache_destroy(cifs_mid_cachep);
                mempool_destroy(cifs_mid_poolp);
+               kmem_cache_destroy(cifs_mid_cachep);
                return -ENOMEM;
        }
 
-
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to