Gitweb:     
http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=da9bc7263dc7e32d52dd922fe3f46eb7107c0143
Commit:     da9bc7263dc7e32d52dd922fe3f46eb7107c0143
Parent:     fbf6ede2ce05592661cec04e04b88f6bab00eb09
Author:     Ralf Baechle <[EMAIL PROTECTED]>
AuthorDate: Thu May 24 14:56:58 2007 +0100
Committer:  Ralf Baechle <[EMAIL PROTECTED]>
CommitDate: Mon Jun 11 18:20:53 2007 +0100

    [MIPS] SMTC: Don't set and restore irqregs ptr from self_ipi.
    
    This did corrupt register s0 which the caller of self_ipi expects to
    be unchanged.  This is a kernel bug which will only be triggered with
    the compilers which compile __smtc_ipi_replay to use s0 across the
    invocation of self_ipi. Gcc 4.1.2 does this, for example.
    
    Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]>
---
 arch/mips/kernel/smtc-asm.S |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/arch/mips/kernel/smtc-asm.S b/arch/mips/kernel/smtc-asm.S
index 921207c..20938a4 100644
--- a/arch/mips/kernel/smtc-asm.S
+++ b/arch/mips/kernel/smtc-asm.S
@@ -121,10 +121,7 @@ LEAF(self_ipi)
        subu    t1,sp,PT_SIZE
        sw      ra,PT_EPC(t1)
        sw      a0,PT_PADSLOT4(t1)
-       LONG_L  s0, TI_REGS($28)
-       LONG_S  sp, TI_REGS($28)
        la      t2,ipi_decode
-       LONG_S  s0, TI_REGS($28)
        sw      t2,PT_PADSLOT5(t1)
        /* Save pre-disable value of TCStatus */
        sw      t0,PT_TCSTATUS(t1)
-
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to