Commit:     e2d8e314ad18d4302b3b7ea21ab8b2cb72f2b152
Parent:     d258131aaea8a3979f82c0313b9a583130b29981
Author:     Yasuyuki Kozakai <[EMAIL PROTECTED]>
AuthorDate: Fri Jun 22 14:10:22 2007 -0700
Committer:  David S. Miller <[EMAIL PROTECTED]>
CommitDate: Fri Jun 22 14:10:22 2007 -0700

    [NETFILTER]: nfctnetlink: Don't allow to change helper
    There is no realistic situation to change helper (Who wants IRC helper to
    track FTP traffic ?). Moreover, if we want to do that, we need to fix race
    issue by nfctnetlink and running helper. That will add overhead to packet
    processing. It wouldn't pay. So this rejects the request to change
    helper. The requests to add or remove helper are accepted as ever.
    Signed-off-by: Yasuyuki Kozakai <[EMAIL PROTECTED]>
    Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]>
    Signed-off-by: David S. Miller <[EMAIL PROTECTED]>
 net/netfilter/nf_conntrack_netlink.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/net/netfilter/nf_conntrack_netlink.c 
index 3f73327..d0fe3d7 100644
--- a/net/netfilter/nf_conntrack_netlink.c
+++ b/net/netfilter/nf_conntrack_netlink.c
@@ -869,8 +869,7 @@ ctnetlink_change_helper(struct nf_conn *ct, struct nfattr 
                return 0;
        if (help->helper)
-               /* we had a helper before ... */
-               nf_ct_remove_expectations(ct);
+               return -EBUSY;
        /* need to zero data of old helper */
        memset(&help->help, 0, sizeof(help->help));
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at

Reply via email to