Gitweb:     
http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=55f3952d45a439cecc36fd845a87026d04c82931
Commit:     55f3952d45a439cecc36fd845a87026d04c82931
Parent:     62877f6b0c4943c2231b84b49182a078eb02a777
Author:     Tejun Heo <[EMAIL PROTECTED]>
AuthorDate: Mon Jun 25 21:31:05 2007 +0900
Committer:  Jeff Garzik <[EMAIL PROTECTED]>
CommitDate: Wed Jun 27 02:44:18 2007 -0400

    libata: kill the infamous abnormal status message
    
    The infamous abnormal status message triggers on not so abnormal cases
    including empty port and even when it's being triggered on actual
    errors the info it provides is redundant and out of context - higher
    level functions will print the info in better safe later anyway.
    
    Also, by being triggered all the time, it leads people to think that
    the abnormality is somehow related to all ATA and system problems
    they're experiencing and gives owners of healthy systems unfounded
    doubts about the integrity of the universe.  Make it a DPRINTK and
    save the universe.
    
    Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
    Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]>
---
 include/linux/libata.h |    8 +++-----
 1 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/include/linux/libata.h b/include/linux/libata.h
index 745c4f9..a3380f8 100644
--- a/include/linux/libata.h
+++ b/include/linux/libata.h
@@ -1088,11 +1088,9 @@ static inline u8 ata_wait_idle(struct ata_port *ap)
 {
        u8 status = ata_busy_wait(ap, ATA_BUSY | ATA_DRQ, 1000);
 
-       if (status != 0xff && (status & (ATA_BUSY | ATA_DRQ))) {
-               if (ata_msg_warn(ap))
-                       printk(KERN_WARNING "ATA: abnormal status 0x%X on port 
0x%p\n",
-                               status, ap->ioaddr.status_addr);
-       }
+       if (status != 0xff && (status & (ATA_BUSY | ATA_DRQ)))
+               DPRINTK("ATA: abnormal status 0x%X on port 0x%p\n",
+                       status, ap->ioaddr.status_addr);
 
        return status;
 }
-
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to