Gitweb:     
http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=f057131fb6eb2c45f6023e3da41ccd6e4e71aee9
Commit:     f057131fb6eb2c45f6023e3da41ccd6e4e71aee9
Parent:     333408f21590d50397f3004e3f87070fa8f52c51
Author:     Jelle Foks <[EMAIL PROTECTED]>
AuthorDate: Mon May 21 14:56:17 2007 -0300
Committer:  Mauro Carvalho Chehab <[EMAIL PROTECTED]>
CommitDate: Tue Jul 3 15:11:16 2007 -0300

    V4L/DVB (5816): Cx88-blackbird: fix vidioc_g_tuner never ending list of 
tuners
    
    v4l-info and other programs would loop indefinitely while querying the
    tuners for cx88-blackbird cards.
    
    The cause was that vidioc_g_tuner didn't return an error value for
    qctrl->id != 0, making the application think there is a never ending
    list of tuners...
    
    This patch adds the same index check as done in vidioc_g_tuner() in
    cx88-video.
    
    Signed-off-by: Jelle Foks <[EMAIL PROTECTED]>
    Signed-off-by: Michael Krufky <[EMAIL PROTECTED]>
    Signed-off-by: Mauro Carvalho Chehab <[EMAIL PROTECTED]>
---
 drivers/media/video/cx88/cx88-blackbird.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/media/video/cx88/cx88-blackbird.c 
b/drivers/media/video/cx88/cx88-blackbird.c
index b0466b8..a80b1cb 100644
--- a/drivers/media/video/cx88/cx88-blackbird.c
+++ b/drivers/media/video/cx88/cx88-blackbird.c
@@ -1034,6 +1034,8 @@ static int vidioc_g_tuner (struct file *file, void *priv,
 
        if (unlikely(UNSET == core->tuner_type))
                return -EINVAL;
+       if (0 != t->index)
+               return -EINVAL;
 
        strcpy(t->name, "Television");
        t->type       = V4L2_TUNER_ANALOG_TV;
-
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to