Gitweb:     
http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=4ae47c2ddc55e3c571bb55fca921cfe9b02a685f
Commit:     4ae47c2ddc55e3c571bb55fca921cfe9b02a685f
Parent:     15d317587e17dcb96484e46b17b6e826a1f97661
Author:     Francois Romieu <[EMAIL PROTECTED]>
AuthorDate: Sat Jun 16 23:28:45 2007 +0200
Committer:  Jeff Garzik <[EMAIL PROTECTED]>
CommitDate: Sun Jul 8 22:16:43 2007 -0400

    r8169: de-obfuscate modulo arithmetic
    
    The former style suggests a modulo arithmetic misuse but
    the expression should never be < 0. Even if it does, the
    driver will simply loop longer than expected (not that
    the remaining parts of the system will necessarily
    appreciate it...).
    
    Let's warn the user when something goes wrong and try
    to go over it.
    
    Signed-off-by: Francois Romieu <[EMAIL PROTECTED]>
    Cc: Edward Hsu <[EMAIL PROTECTED]>
---
 drivers/net/r8169.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c
index 4586446..1f7fb54 100644
--- a/drivers/net/r8169.c
+++ b/drivers/net/r8169.c
@@ -2040,10 +2040,12 @@ static u32 rtl8169_rx_fill(struct rtl8169_private *tp, 
struct net_device *dev,
 {
        u32 cur;
 
-       for (cur = start; end - cur > 0; cur++) {
+       for (cur = start; end - cur != 0; cur++) {
                struct sk_buff *skb;
                unsigned int i = cur % NUM_RX_DESC;
 
+               WARN_ON((s32)(end - cur) < 0);
+
                if (tp->Rx_skbuff[i])
                        continue;
 
-
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to