Commit:     825cd6dd793770ebd42d9ca19f5ee7d082350317
Parent:     5f45bc50976ee1f408f7171af155aec646655a37
Author:     Mikael Pettersson <[EMAIL PROTECTED]>
AuthorDate: Tue Jul 3 01:10:25 2007 +0200
Committer:  Jeff Garzik <[EMAIL PROTECTED]>
CommitDate: Mon Jul 9 12:17:34 2007 -0400

    sata_sil24: sil24_interrupt() micro-optimisation
    sil24_interrupt() loads host->ports[i] into a local variable,
    validates it, and then loads the value again in the call to
    sil24_host_intr(). This patch replaces the second load by a
    reference to the local variable.
    This is safe since no side-effects have occurred since the
    initial load. It also improves readability since it makes
    it clear that the parameter to sil24_host_intr() is the same
    value which was just validated.
    Signed-off-by: Mikael Pettersson <[EMAIL PROTECTED]>
    Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]>
 drivers/ata/sata_sil24.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/ata/sata_sil24.c b/drivers/ata/sata_sil24.c
index 0ddfae9..14261f3 100644
--- a/drivers/ata/sata_sil24.c
+++ b/drivers/ata/sata_sil24.c
@@ -888,7 +888,7 @@ static irqreturn_t sil24_interrupt(int irq, void 
                if (status & (1 << i)) {
                        struct ata_port *ap = host->ports[i];
                        if (ap && !(ap->flags & ATA_FLAG_DISABLED)) {
-                               sil24_host_intr(host->ports[i]);
+                               sil24_host_intr(ap);
                        } else
                                printk(KERN_ERR DRV_NAME
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at

Reply via email to