Gitweb:     
http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=91e8db80065d655ce1b6d74cadc921671e8d5285
Commit:     91e8db80065d655ce1b6d74cadc921671e8d5285
Parent:     d3c3f4243e135b3d8c41d98be0cb2f54a4141abf
Author:     Patrick McHardy <[EMAIL PROTECTED]>
AuthorDate: Sat Jul 7 22:38:54 2007 -0700
Committer:  David S. Miller <[EMAIL PROTECTED]>
CommitDate: Tue Jul 10 22:18:18 2007 -0700

    [NETFILTER]: nf_conntrack_h323: turn some printks into DEBUGPs
    
    Don't spam the ringbuffer with decoding errors. The only printks remaining
    are for dropped packets when we're certain they are H.323.
    
    Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]>
    Signed-off-by: David S. Miller <[EMAIL PROTECTED]>
---
 net/netfilter/nf_conntrack_h323_main.c |   25 ++++++++++---------------
 1 files changed, 10 insertions(+), 15 deletions(-)

diff --git a/net/netfilter/nf_conntrack_h323_main.c 
b/net/netfilter/nf_conntrack_h323_main.c
index 8c57b81..aa5ba99 100644
--- a/net/netfilter/nf_conntrack_h323_main.c
+++ b/net/netfilter/nf_conntrack_h323_main.c
@@ -163,9 +163,7 @@ static int get_tpkt_data(struct sk_buff **pskb, unsigned 
int protoff,
                                }
 
                                /* Fragmented TPKT */
-                               if (net_ratelimit())
-                                       printk("nf_ct_h323: "
-                                              "fragmented TPKT\n");
+                               DEBUGP("nf_ct_h323: fragmented TPKT\n");
                                goto clear_out;
                        }
 
@@ -596,10 +594,9 @@ static int h245_help(struct sk_buff **pskb, unsigned int 
protoff,
                ret = DecodeMultimediaSystemControlMessage(data, datalen,
                                                           &mscm);
                if (ret < 0) {
-                       if (net_ratelimit())
-                               printk("nf_ct_h245: decoding error: %s\n",
-                                      ret == H323_ERROR_BOUND ?
-                                      "out of bound" : "out of range");
+                       DEBUGP("nf_ct_h245: decoding error: %s\n",
+                              ret == H323_ERROR_BOUND ?
+                              "out of bound" : "out of range");
                        /* We don't drop when decoding error */
                        break;
                }
@@ -1137,10 +1134,9 @@ static int q931_help(struct sk_buff **pskb, unsigned int 
protoff,
                /* Decode Q.931 signal */
                ret = DecodeQ931(data, datalen, &q931);
                if (ret < 0) {
-                       if (net_ratelimit())
-                               printk("nf_ct_q931: decoding error: %s\n",
-                                      ret == H323_ERROR_BOUND ?
-                                      "out of bound" : "out of range");
+                       DEBUGP("nf_ct_q931: decoding error: %s\n",
+                              ret == H323_ERROR_BOUND ?
+                              "out of bound" : "out of range");
                        /* We don't drop when decoding error */
                        break;
                }
@@ -1711,10 +1707,9 @@ static int ras_help(struct sk_buff **pskb, unsigned int 
protoff,
        /* Decode RAS message */
        ret = DecodeRasMessage(data, datalen, &ras);
        if (ret < 0) {
-               if (net_ratelimit())
-                       printk("nf_ct_ras: decoding error: %s\n",
-                              ret == H323_ERROR_BOUND ?
-                              "out of bound" : "out of range");
+               DEBUGP("nf_ct_ras: decoding error: %s\n",
+                      ret == H323_ERROR_BOUND ?
+                      "out of bound" : "out of range");
                goto accept;
        }
 
-
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to